Update test_ftu_skip_tour setup

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Bebe, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Set 'time.timezone.user-selected' to None  in the test setup to be able to test time zone auto detection
(Reporter)

Comment 1

4 years ago
Created attachment 8492141 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24218
Attachment #8492141 - Flags: review?(zcampbell)
Attachment #8492141 - Flags: review?(robert.chira)

Comment 2

4 years ago
Comment on attachment 8492141 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24218

r-, we should put this in the testvars file, so we don't  modify the device in cases where the tester is not setting a timezone.
Attachment #8492141 - Flags: review?(zcampbell) → review-
(Reporter)

Comment 3

4 years ago
Zac we already have this setting in the test vars 
https://github.com/mozilla/webqa-credentials/blob/master/b2g/b2g-17.2.json#L18

Because of this we see the bug described in Bug 1068616 
What my pull does is revert the setting we have in testvars 

That setting is there to prevent some issues with the calendar tests.

Comment 4

4 years ago
Comment on attachment 8492141 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24218

r+ conditional upon adding the comment to it.
Attachment #8492141 - Flags: review- → review+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

4 years ago
we need this uplifted to V2.1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 8493154 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24295

uplift to v2.1
Attachment #8493154 - Flags: review?(robert.chira)
Attachment #8493154 - Flags: review?(florin.strugariu)
(Reporter)

Updated

4 years ago
Attachment #8493154 - Flags: review?(robert.chira)
Attachment #8493154 - Flags: review?(florin.strugariu)
Attachment #8493154 - Flags: review+
(Reporter)

Comment 8

4 years ago
https://github.com/mozilla-b2g/gaia/commit/2c5f245929d40ee7b0227ef39e47a0220171d17b
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.