Closed Bug 1069965 Opened 9 years ago Closed 9 years ago

Add a visual separator between available and blocked contacts in the Contacts List

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

(firefox35 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla35
Iteration:
35.2
Tracking Flags:
Tracking Status
firefox35 --- verified

People

(Reporter: mikedeboer, Assigned: mikedeboer)

References

Details

(Whiteboard: [contacts][strings][no-loop-uplift][fig:wontverify][qablocked:1038257])

Attachments

(1 file)

Patch v1: add a visual separator between available and blocked contacts
4.08 KB, patch
mikedeboer
: review+
Details | Diff | Splinter Review 
See summary.

This patch requires a new string, so it's not eligable for uplift, unfortunately.

Already has a patch, carrying over r=paolo.
Attachment #8492207 - Flags: review+
Flags: qe-verify+
Flags: needinfo?(mmucci)
Flags: firefox-backlog+
Added to IT 35.2
Flags: needinfo?(mmucci)
Whiteboard: [contacts] [qa+] → [contacts] [qa+] [strings]
Whiteboard: [contacts] [qa+] [strings] → [contacts] [qa+] [strings][no-loop-uplift]
https://hg.mozilla.org/mozilla-central/rev/1a986002b264
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Whiteboard: [contacts] [qa+] [strings][no-loop-uplift] → [contacts][strings][no-loop-uplift]
To test this I need to be able to add contacts. How can I do that in the current Nightly?
Paul, once comment 4 has been answered, can you please verify this in the latest Nightly and the Fig builds here: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/rjesup@wgate.com-f9eb2cbac352
Flags: needinfo?(paul.silaghi)
QA Contact: anthony.s.hughes → paul.silaghi
Whiteboard: [contacts][strings][no-loop-uplift] → [contacts][strings][no-loop-uplift][fig:verifyme]
Upon further review of the issues flagged for pre-uplift verification, I do not think this needs verification before we uplift. Paul, please still verify this in the latest Nightly but skip verification in the Fig branch.
Whiteboard: [contacts][strings][no-loop-uplift][fig:verifyme] → [contacts][strings][no-loop-uplift][fig:wontverify]
Sorry, I forgot this is a special case.

Paul, when testing this you'll want to verify that it's fixed in Nightly but not fixed in Fig. The patch contains a non-localized string so we can't uplift it.
Whiteboard: [contacts][strings][no-loop-uplift][fig:wontverify] → [contacts][strings][no-loop-uplift][fig:verifyme]
You will be able to add contacts and test this in Nightly when bug 1038257 is resolved.
(In reply to :Paolo Amadini from comment #8)
> You will be able to add contacts and test this in Nightly when bug 1038257
> is resolved.

Wont verify for Fig since this is not testable until bug 1038257 lands.
Whiteboard: [contacts][strings][no-loop-uplift][fig:verifyme] → [contacts][strings][no-loop-uplift][fig:wontverify][qablocked:1038257]
Verified fixed FF 35.0a1 (2014-10-03) Win 7, OS X 10.9.5, Ubuntu 13.04
Status: RESOLVED → VERIFIED
status-firefox35: --- → verified
Flags: needinfo?(paul.silaghi)
Comment on attachment 8492207 [details] [diff] [review]
Patch v1: add a visual separator between available and blocked contacts

Approval Request Comment
Uplift request for patches staged and tested on Fig
Attachment #8492207 - Flags: approval-mozilla-aurora?
Comment on attachment 8492207 [details] [diff] [review]
Patch v1: add a visual separator between available and blocked contacts

incorrectly mass-marked
Attachment #8492207 - Flags: approval-mozilla-aurora?
Depends on: 1079941
You need to log in before you can comment on or make changes to this bug.