1070006 - [calendar] unit test change chai.assert api in the new version

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[sv99]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20140917114326

Steps to reproduce:

test_agent used very old version chai library version=0.5.3
in the current version=1.9.1 same api chenged 

1. assert.length -> assert.lengthOf
2. assert.deepEqual(arguments, [x,x, ... ]) -> assert.deepEqual(Array.slice(arguments))

Comment 1

[sv99]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24227

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 8492256 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24227

Redirecting to a peer for Calendar.

Hey Kevin, the goal is to move to a newer Chai which has issues with some of the test code we use currently. Looks like the changes are backward compatible and Gu is still green, but maybe you want to look closer :)

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8492256 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24227

Gu is green so I am happy and will leave an R+ here. Thanks!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/ab732d719c94f16bf65f54032519e8d015d93226