Closed Bug 1070092 Opened 8 years ago Closed 8 years ago
Support data: URIs for images in 'link rel' tags
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 Build ID: 20140830210550 Steps to reproduce: open site which has 'link rel=icon ' and 'href=data/image Actual results: no favicon shown Expected results: show favicon (as firefox desktop would do)
We can *already* do this, we just special-cased it hideously for the search engine stuff. While I'm here I might as well give Bug 961600 a stab
Assignee: nobody → chriskitching
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Ta-Da: https://www.dropbox.com/s/nqc8buxmnyb966v/DataURIFavicon.png?dl=0 Thanks for the report!
OS: Linux → Android
Hardware: x86_64 → All
Summary: support data-uri for images in 'link rel' tags → Support data: URIs for images in 'link rel' tags
Version: Firefox 32 → Trunk
Comment on attachment 8492483 [details] [diff] [review] Support favicon data URIs Review of attachment 8492483 [details] [diff] [review]: ----------------------------------------------------------------- r+ if you remove the second error logging clause from decodeDataURI. Just turn the log statement into a comment and return. ::: mobile/android/base/favicons/LoadFaviconTask.java @@ +361,5 @@ > > + // Attempt to decode the favicon URL as a data URL. We don't bother storing such URIs in > + // the database: the cost of decoding them here probably doesn't exceed the cost of mucking > + // about with the DB. > + LoadFaviconResult uriBitmaps = FaviconDecoder.decodeDataURI(faviconURL); This will cause log spam, no? FaviconDecoder calls Log.w if the URI is non-data.
Attachment #8492483 - Flags: review?(rnewman) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Verified as fixed in Firefox for Android 35.0; Device: Asus Transformer Pad TF300T (Android 4.2.1).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.