Support data: URIs for images in 'link rel' tags

VERIFIED FIXED in Firefox 35

Status

()

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: max.schulze, Assigned: ckitching)

Tracking

Trunk
Firefox 35
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140830210550

Steps to reproduce:

open site which has 'link rel=icon ' and 'href=data/image


Actual results:

no favicon shown


Expected results:

show favicon (as firefox desktop would do)
Posted patch Support favicon data URIs (obsolete) — Splinter Review
We can *already* do this, we just special-cased it hideously for the search engine stuff. While I'm here I might as well give Bug 961600 a stab
Attachment #8492482 - Flags: review?(rnewman)
Assignee: nobody → chriskitching
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8492483 - Flags: review?(rnewman)
Attachment #8492482 - Attachment is obsolete: true
Attachment #8492482 - Flags: review?(rnewman)
Blocks: 961600
OS: Linux → Android
Hardware: x86_64 → All
Summary: support data-uri for images in 'link rel' tags → Support data: URIs for images in 'link rel' tags
Version: Firefox 32 → Trunk
Comment on attachment 8492483 [details] [diff] [review]
Support favicon data URIs

Review of attachment 8492483 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if you remove the second error logging clause from decodeDataURI. Just turn the log statement into a comment and return.

::: mobile/android/base/favicons/LoadFaviconTask.java
@@ +361,5 @@
>  
> +        // Attempt to decode the favicon URL as a data URL. We don't bother storing such URIs in
> +        // the database: the cost of decoding them here probably doesn't exceed the cost of mucking
> +        // about with the DB.
> +        LoadFaviconResult uriBitmaps = FaviconDecoder.decodeDataURI(faviconURL);

This will cause log spam, no? FaviconDecoder calls Log.w if the URI is non-data.
Attachment #8492483 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/dbc507f70c90
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Verified as fixed in Firefox for Android 35.0;
Device: Asus Transformer Pad TF300T (Android 4.2.1).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.