bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

In Sync preferences, the manage account link should only link to manage that account

VERIFIED FIXED in Firefox 40

Status

()

Firefox
Sync
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: rfeeley, Assigned: markh)

Tracking

35 Branch
Firefox 40
Points:
2
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox40 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8492360 [details]
manage.gif

Currently in Sync preferences, the Manage link goes to /settings on the web. The URL should contain a hash of an email address that will bring the user to the setting page for that specific account, so that they don't accidentally modify the settings of a different account they had authenticated on the web.
Hardware: x86 → All
We fixed this in the FxA web code. If you add uid=<fxa uid> to the query params of the settings link, we'll show the correct settings page if the user is currently authenticated on the Web. Otherwise, we'll prompt the user to log in.
(Assignee)

Comment 2

3 years ago
Sounds like a simple but worthwhile fix the client can make.
Points: --- → 2
Flags: qe-verify+
Flags: firefox-backlog+
(Reporter)

Comment 3

3 years ago
Gavin, has this made the priority backlog?
Flags: needinfo?(gavin.sharp)
No, but maybe Mark can write a patch very quickly.
Flags: needinfo?(gavin.sharp)
(Reporter)

Comment 5

3 years ago
Would it work for the manage account link in Hello too or should I file a separate bug for that?
That's already filed as bug 1070208 (in the See Also field).
(Assignee)

Comment 7

3 years ago
Created attachment 8596940 [details] [diff] [review]
0001-Bug-1070115-pass-the-uid-of-the-current-FxA-user-to-.patch

Adds a promiseAccountsManageURI to FxAccounts.jsm and has the sync pref's panel call that.
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Attachment #8596940 - Flags: review?(zack.carter)
Comment on attachment 8596940 [details] [diff] [review]
0001-Bug-1070115-pass-the-uid-of-the-current-FxA-user-to-.patch

Review of attachment 8596940 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good with comment addressed.

::: services/fxaccounts/FxAccounts.jsm
@@ +1231,5 @@
> +      if (!accountData) {
> +        return null;
> +      }
> +      let newQueryPortion = url.indexOf("?") == -1 ? "?" : "&";
> +      newQueryPortion += "uid=" + encodeURIComponent(accountData.uid);

We should also add an email query parameter for the fallback scenario: when there's no account with that uid in localStorage we show /signin with the provided email pre-filled.
Attachment #8596940 - Flags: review?(zack.carter) → review+

Updated

3 years ago
Iteration: --- → 40.2 - 27 Apr
https://hg.mozilla.org/mozilla-central/rev/d03a3e5aaf86
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
QA Contact: catalin.varga
I verified this bug using 
FF 40
Build Id: 20150427030207
OS: Win 7 x64, Mac Os X 10.9.5, Ubuntu 14.04 x64

When pressing the manage button from about:preferences#sync the settings page of the account is opened and the url format contains the email and uid eg: (https://accounts.firefox.com/settings?uid=41276d2ce9aa4b29aa394cb4ee44ceb9&email=cascavaca%40mailinator.com)
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
You need to log in before you can comment on or make changes to this bug.