Closed
Bug 1070146
Opened 10 years ago
Closed 10 years ago
Resource timing for scripts has responseStart and several attributes set to 0
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: valentin, Assigned: valentin)
References
Details
Attachments
(1 file)
3.94 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
http://w3c-test.org/resource-timing/test_resource_timing.html The test for resource_timing_test0.js fails and several of its attributes are 0. Also, looking at the entries for the other scripts - same thing. This is clearly a bug.
Assignee | ||
Comment 1•10 years ago
|
||
It seems that channels for .js and .ico files have a null loadInfo, so nsPerformanceTiming::CheckAllowedOrigin returns false. http://dxr.mozilla.org/mozilla-central/source/dom/base/nsPerformance.cpp#93 Is this the correct behaviour or a known issue?
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 2•10 years ago
|
||
Correction: only the .js channels have a null loadInfo.
Comment 3•10 years ago
|
||
> Is this the correct behaviour or a known issue? More of the latter, I think. Right now, all sorts of channels have no loadinfo. See bug 1038756, which ought to help.
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 4•10 years ago
|
||
I have tested with the patches from bug 1038756 and the attributes are no longer 0. Will retest and close this bug once that lands (seems to be very close).
Depends on: 1038756
Assignee | ||
Comment 5•10 years ago
|
||
Bug 1038756 landed and fixed this issue. Adding test to prevent future regressions.
Attachment #8494112 -
Flags: review?(bzbarsky)
Comment 6•10 years ago
|
||
Comment on attachment 8494112 [details] [diff] [review] Test resource timing info for script resources r=me
Attachment #8494112 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Try run: https://tbpl.mozilla.org/?tree=Try&rev=71a9cb02ab26
Keywords: checkin-needed
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/da5c4c9ee9b6
Keywords: checkin-needed
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/da5c4c9ee9b6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•