Closed Bug 1070148 Opened 6 years ago Closed 6 years ago

Copy maintenance service binary into its install directory when the installed binary is different

Categories

(Toolkit :: Application Update, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(2 files, 4 obsolete files)

Currently the maintenance service binary used during testing can be different than the one we want to test. This is due to the install script that installs the base version that we upgrade only runs during system startup so if a system runs nightly tests and then runs aurora tests the installed maintenance service will be the nightly version since the version check prevents installing older versions.

To get around this, write access will be granted to the account running tests so it can just copy in the version we want to test if it is different. It appears that the account running the tests already has write access on WinXP and Win7.
Attached patch patch for oak (obsolete) — Splinter Review
If this passes then I am going to land this on oak to get rid of the oranges and I will back it out and land the final patch after the build system changes have been completed.
Attachment #8492542 - Attachment is obsolete: true
Temporary patch pushed to oak
https://hg.mozilla.org/projects/oak/rev/ca84f1f950b1
Attachment #8492681 - Attachment is obsolete: true
Note: the workaround patch makes it so marStageSuccessCompleteSvc.js and marStageSuccessPartialSvc.js don't run on WinXP and Win8 when the installed maintenance service isn't the same as the build's maintenance service. Both marStageSuccessCompleteSvc.js and marStageSuccessPartialSvc.js run on Win7 and all of the other tests run on all versions of Windows.
Forgot to qrefresh

Backed out and pushed the updated patch to oak
Attachment #8492687 - Attachment is obsolete: true
Comment on attachment 8492690 [details] [diff] [review]
patch - temporary workaround for oak

This is a temporary workaround that we might need to land before the complete fix is available after the build systems have been configured to allow the tests to copy the binary into the maintenance service install directory. It prevents 2 of the tests from running on anything but Win7 (since the tests have write access to the maintenance service install directory on Win7) if the installed maintenance service binary is different from the build's maintenance service binary.
Attachment #8492690 - Flags: review?(netzen)
Comment on attachment 8492690 [details] [diff] [review]
patch - temporary workaround for oak

Review of attachment 8492690 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/update/tests/unit_aus_update/head_update.js
@@ +1582,5 @@
>   * @param  aFirstTest
>   *         Whether this is the first test within the test.
> + * @param  aSkipTest
> + *         Whether to skip this test if the installed maintenance service
> + *         isn't the same as the build's maintenance service.

Please indicate here that this is a temporary work around that will be removed.  In case someone reads the landed code and wonders.

@@ +1925,5 @@
> +  var isWin7 = (parseFloat(version) == 6.1);
> +  // The account running the tests on Win 7 build systems appear to have write
> +  // access to the maintenance service directory so throw if copying the
> +  // maintenance service binary fails.
> +  if (isWin7) {

Do we know why this is the case? Might be worth asking releng to confirm that they have opened up write access into program files or to this dir in particular.
Attachment #8492690 - Flags: review?(netzen) → review+
I just got word that the build system changes will likely be pushed out soon as in possibly even today.
addressed comments and now that we have write access on xp made it so the test throws on xp when we don't have write access just as it does for Win7.

Backed out old patch and relanded
https://hg.mozilla.org/projects/oak/rev/e53f537c0569
Attachment #8492690 - Attachment is obsolete: true
Attachment #8496505 - Flags: review+
try push that shows write access is available on WinXP and Win7
https://tbpl.mozilla.org/?tree=Try&rev=39cf2972ed51

Try push with the new patch
https://tbpl.mozilla.org/?tree=Try&rev=5a038c179aab
https://hg.mozilla.org/mozilla-central/rev/972e4d9da1b5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.