1070223 - Ignore exceptions thrown from nsIBrowserSearchInitObserver

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Dave Townsend [:mossop]]

Attachment: patch

The observer could throw an exception, in particular in testing urlbarBindings sometimes does this if windows or tabs are closed before the service initialises. This is causing the jetpack tests to show errors about uncaught promise rejections. So this just wraps in a try...catch.

Comment 1

[Matthew N. [:MattN]]

Is this the same as bug 1068437?

Comment 2

[Dave Townsend [:mossop]]

Uhh yes!

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8492432 [details] [diff] [review]
patch

Review of attachment 8492432 [details] [diff] [review]:
-----------------------------------------------------------------

It seems like this won't hurt. I would definitely run the various search tests to make sure this behaviour isn't tested and expecting an exception/rejection.

::: toolkit/components/search/nsSearchService.js
@@ +3873,5 @@
>          function onSuccess() {
> +          try {
> +            observer.onInitComplete(self._initRV);
> +          }
> +          catch (e) {

Nit: Cuddle the catch

@@ +3874,5 @@
> +          try {
> +            observer.onInitComplete(self._initRV);
> +          }
> +          catch (e) {
> +            Components.utils.reportError(e);

Nit: Cu is already defined so you can use: Cu.reportError(e);
I'm not sure why the one below isn't using Cu

Comment 4

[Dave Townsend [:mossop]]

Landed: https://hg.mozilla.org/integration/fx-team/rev/af6a5156818f

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/af6a5156818f