1070268 - add FindChildElements endpoint

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

In WebDriver when we find a child element

 > element.find_element('search', 'value')

it calls findChildElement. We need to add an alias for this for webdriver compat

Comment 1

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=6a332d1607be

Comment 2

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=46cd1584f414

Comment 3

[David Burns :automatedtester]

Attachment: Add findChildElements endpoint to Marionette for WebDriver compatibility

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8493665 [details] [diff] [review]
Add findChildElements endpoint to Marionette for WebDriver compatibility

Review of attachment 8493665 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-server.js
@@ +1622,5 @@
>    },
>  
>    /**
> +   * Find element using the indicated search strategy
> +   * starting from a known element. Used for WebDriver Compatibility only

nit: should have a period at EOL

@@ +1625,5 @@
> +   * Find element using the indicated search strategy
> +   * starting from a known element. Used for WebDriver Compatibility only
> +   * @param  {object} aRequest
> +   *         'using' member indicates which search method to use
> +   *         'value' member is the value the client is looking for

We should document the 'id' member too, although I realize this was just copy/pasted from the findElement block, which is also missing members in the doctstring.

@@ +1680,5 @@
>    },
>  
>    /**
> +   * Find elements using the indicated search strategy
> +   * starting from a known element. Used for WebDriver Compatibility only

nit: should have period at EOL

@@ +1683,5 @@
> +   * Find elements using the indicated search strategy
> +   * starting from a known element. Used for WebDriver Compatibility only
> +   * @param  {object} aRequest
> +   *         'using' member indicates which search method to use
> +   *         'value' member is the value the client is looking for

Ditto above re: missing members in the docstring.

@@ +2657,2 @@
>    "findElements": MarionetteServerConnection.prototype.findElements,
> +  "findChildElements":MarionetteServerConnection.prototype.findChildElements, // Needed for WebDriver Compat

nit: Compat shouldn't be capitalized

Comment 5

[David Burns :automatedtester]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8b6fea13c4f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c8b6fea13c4f