Closed Bug 1070316 Opened 5 years ago Closed 5 years ago

factor out descriptor storage from nsCSSFontFaceStyleDecl

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

If we factor our the descriptor storage from nsCSSFontFaceStyleDecl into a separate struct, I can reuse it in bug 1028497 when storing descriptors on a FontFace object.  It also encapsulates the field offset pointer lookups into the object.
Attached patch patchSplinter Review
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8492487 - Flags: review?(dbaron)
Blocks: 1028497
Comment on attachment 8492487 [details] [diff] [review]
patch

r=dbaron

(I'm not sure whether to suggest putting the Get methods inline, but the way you have it is probably fine.)
Attachment #8492487 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/c94ef44023a4
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.