Closed Bug 1070316 Opened 10 years ago Closed 10 years ago

factor out descriptor storage from nsCSSFontFaceStyleDecl

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

patch
8.74 KB, patch
dbaron
: review+
Details | Diff | Splinter Review 
If we factor our the descriptor storage from nsCSSFontFaceStyleDecl into a separate struct, I can reuse it in bug 1028497 when storing descriptors on a FontFace object.  It also encapsulates the field offset pointer lookups into the object.
Attached patch patch — — Splinter Review 
Assignee: nobody → cam
Status: NEW → ASSIGNED

        Attachment #8492487 -
        Flags: review?(dbaron)

    
  
Blocks: 1028497

    
    

    
  
Comment on attachment 8492487 [details] [diff] [review]
patch

r=dbaron

(I'm not sure whether to suggest putting the Get methods inline, but the way you have it is probably fine.)

        Attachment #8492487 -
        Flags: review?(dbaron) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c94ef44023a4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: