mozilla::pkix's pkixbuild_tests uses NSS directly

RESOLVED FIXED in mozilla37

Status

()

Core
Security: PSM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: briansmith, Assigned: briansmith)

Tracking

Trunk
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

pkixbuild_tests.cpp is the only test that uses NSS directly. We should modify it so that it doesn't use NSS at all. To do so, we need to change the implementation of the FindIssuers function and the CERTCertificate-using code related to that, and then remove the call to NSS_NoDB_Init.
Blocks: 1033561
OS: Windows 8.1 → All
Hardware: x86 → All
Target Milestone: --- → mozilla37
Created attachment 8540559 [details] [diff] [review]
bug-1070444.patch
Assignee: nobody → brian
Status: NEW → ASSIGNED
Attachment #8540559 - Flags: review?(dkeeler)
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8854de9dd30a
Comment on attachment 8540559 [details] [diff] [review]
bug-1070444.patch

Review of attachment 8540559 [details] [diff] [review]:
-----------------------------------------------------------------

Great - thanks for taking care of this.
Attachment #8540559 - Flags: review?(dkeeler) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f90deb1be15

Thanks for the quick review turnaround!
https://hg.mozilla.org/mozilla-central/rev/2f90deb1be15
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.