1070503 - Async Places Transactions: Delete command implementation

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

Marco, please add this bug to the current iteration.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 8492592 [details] [diff] [review]
patch

wrong file

Comment 4

[Asaf Romano (gone)]

Attachment: patch

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8492607 [details] [diff] [review]
patch

Review of attachment 8492607 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/places/content/controller.js
@@ +872,5 @@
>          var tagItemId = PlacesUtils.getConcreteItemId(node.parent);
>          var uri = NetUtil.newURI(node.uri);
> +        if (PlacesUIUtils.useAsyncTransactions) {
> +          let tag = node.parent.title;
> +          if (!tag) 

trailing space

Comment 6

[Asaf Romano (gone)]

qa- after all. I discussed this with Tim, and we agreed that it'd be better to QA all of this work as whole when it's done.

Comment 7

[Asaf Romano (gone)]

https://hg.mozilla.org/integration/fx-team/rev/8e6043000072

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/8e6043000072