Update (and rename) Bugzilla::Send::Sendmail to work with Email::Sender::Transport::Sendmail

RESOLVED FIXED in Bugzilla 5.0

Status

()

Bugzilla
Email Notifications
--
major
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

4.5.5
Bugzilla 5.0
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Now that we moved from Email::Send to Email::Sender, either Bugzilla/Send/* must be removed, or should be updated to work with Email::Sender::Transport::Sendmail if the original issue reported in bug 715806 is still present. I don't use JobQueue, so I will let glob investigate.

Email::Sender::Transport::Sendmail->send_email() is pretty similar to Email::Send::Sendmail->send(), so I guess the fix shouldn't be too hard if the file is still needed.
> so I will let glob investigate

i won't have time to look at for at least 3 weeks (likely 4), however i'm not the only person who runs jobqueue (and it's pretty easy to setup if you wanted to investigate frédéric).
this should have been fixed as part of bug 502625.

Email::Send is no longer a required package, however we don't pass tests if it isn't installed because Bugzilla/Send/Sendmail doesn't compile.
Severity: normal → major
(Assignee)

Comment 3

3 years ago
Created attachment 8493905 [details] [diff] [review]
patch, v1

I have no way to test this patch, because my ISP blocks sendmail to prevent spam (I can only test SMTP). Testing on Linux and Windows are both welcome.

I renamed Bugzilla/Send/Sendmail.pm to Bugzilla/Sender/Transport/Sendmail.pm.
Attachment #8493905 - Flags: review?(glob)
Attachment #8493905 - Flags: review?(dylan)
Attachment #8493905 - Flags: review?(glob)
I've done half of this; getting a sendmail executable on windows is not something I'm done before, but I'll get around to it this evening.
Status: NEW → ASSIGNED
I did attempt to do this this evening. Trying to use http://velikan.net/sendmail-for-windows-iis/ I ran into problems unrelated to bugzilla code (it won't send mail at all). I have a few higher priority tasks, this may not get poked until this weekend.
(In reply to Dylan William Hardison [:dylan] from comment #4)
> I've done half of this; getting a sendmail executable on windows is not
> something I'm done before, but I'll get around to it this evening.

http://glob.com.au/sendmail/
(In reply to Dylan William Hardison [:dylan] from comment #5)
> I did attempt to do this this evening. Trying to use
> http://velikan.net/sendmail-for-windows-iis/ I ran into problems unrelated
> to bugzilla code (it won't send mail at all). I have a few higher priority
> tasks, this may not get poked until this weekend.

lol, that page uses my sendmail binary (without any docs or credit. boo).
anyhow, grab a more recent version from my site.
Awesome, I had no idea you had a fake sendmail. Now to figure out why it won't talk to my real smtpd...
Comment on attachment 8493905 [details] [diff] [review]
patch, v1

Review of attachment 8493905 [details] [diff] [review]:
-----------------------------------------------------------------

Works for account creation emails, html, plain text, etc.

r=dylan
Attachment #8493905 - Flags: review?(dylan) → review+
To amend my comment, I mean that I was able to get it to work on windows with no difficulty -- provided glob's fake sendmail was installed and the firewall allowed port 25 out. Of course it works on linux, as previously indicated. I'm pretty sure using native SMTP would be preferable on a windows install, of course.
(Assignee)

Updated

3 years ago
Flags: approval?
(Assignee)

Updated

3 years ago
Assignee: email-notifications → LpSolit
Flags: approval? → approval+
(Assignee)

Comment 11

3 years ago
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   f7f98a3..0ff4174  master -> master
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.