1070690 - Remove _setDetailsFieldsDisabledState and paneElementsBroadcaster

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Asaf Romano (gone)]

Attachment: patch

They've been unused since the landing of 407541 six years ago.

Comment 1

[Marco Bonardo [:mak]]

Comment on attachment 8492721 [details] [diff] [review]
patch

Review of attachment 8492721 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/places/content/editBookmarkOverlay.xul
@@ +54,5 @@
>            <label value="&editBookmarkOverlay.siteLocation.label;"
>                   class="editBMPanel_rowLabel"
>                   accesskey="&editBookmarkOverlay.siteLocation.accesskey;"
> +                 control="editBMPanel_siteLocationField"/>
> +          <textbox id="editBMPanel_siteLocationField" class="uri-element"/>

please keep class on a new line

@@ +146,5 @@
>          <row id="editBMPanel_tagsSelectorRow"
>               align="center"
>               collapsed="true">
>            <spacer/>
> +          <listbox id="editBMPanel_tagsSelector" height="150"/>

please keep height on  new line

@@ +164,5 @@
>            <label value="&editBookmarkOverlay.description.label;"
>                   class="editBMPanel_rowLabel"
>                   accesskey="&editBookmarkOverlay.description.accesskey;"
> +                 control="editBMPanel_descriptionField"/>
> +          <textbox id="editBMPanel_descriptionField" multiline="true"/>

same for multiline

Comment 2

[Asaf Romano (gone)]

https://hg.mozilla.org/integration/fx-team/rev/bd637b44a788

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/bd637b44a788