1070691 - Add bookmark dialog: create the dummy item before the dialog opens, and do the transactions batching in the caller

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Comment 1

[Asaf Romano (gone)]

OK, I now remember why even a modal dialog cannot just "return" a set of transactions to be performed. In the "Bookmarks All Tabs" case, there's a new folder button that acts instant-apply (in a user visible manner). In the current UI, this "new folder" command is batched along with all other actions, so that both "Cancel" in the dialog and or a single "Undo" thereafter in the Library undoes both the item changes and the new-folder command.

This alone suggests that a possible solution would be to avoid the dummy-item, and, in the new-folder case just have two or more transactions on the stack: the item changes/cretation at its top, and after that the new folder command(s). This means that cancel would only undo the item changes, but leave in any new folders. This is somewhat in parallel with Save dialogs.

I don't rush to implement that just yet because I would like to figure out the implications, if any, on the Star UI, which also provides this New Folder interaction along with a Cancel button. So far I have been thinking on the Star UI as instant-apply UI regardless of that, but I think I was wrong.

Comment 2

[Asaf Romano (gone)]

Sorry for the misunderstanding. I didn't ask to add this bug to the current iteration for a reason: I'm not yet working on it, and I might even decide to WONTFIX it. This is still in the brainstorming stage.