Closed Bug 1070709 Opened 5 years ago Closed 5 years ago

Collapse test-only moz.build files into ancestor moz.build files

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: poiru, Assigned: poiru)

Details

Attachments

(8 files)

No description provided.
Mechanically, these patches all look fine, but what is the goal? There's no description for why we're doing this, or any blocked bugs that would make it apparent.
Attachment #8492742 - Flags: review?(mshal) → review+
Attachment #8492743 - Flags: review?(mshal) → review+
Attachment #8492744 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #4)
> Mechanically, these patches all look fine, but what is the goal? There's no
> description for why we're doing this, or any blocked bugs that would make it
> apparent.

Apologies, bug 1038535 comment 4 should sum it up pretty well.
Attachment #8561033 - Flags: review?(mshal) → review+
Attachment #8561034 - Flags: review?(mshal) → review+
Attachment #8561035 - Flags: review?(mshal) → review+
Attachment #8561037 - Flags: review?(mshal) → review+
Attachment #8561038 - Flags: review?(mshal) → review+
These all look fine to me. Though if the primary goal is for the build system to do less work, do we have any benchmarks to support that this is helping? I'd like to eventually move to a model where we don't parse every moz.build file every time, in which case having more smaller moz.build files is actually advantageous. I don't think these changes would impact that significantly, though.
Marking as resolved based on comment 13.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.