1070731 - [sms] unit test refactoring for new version chai.assert api

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[sv99]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20140920030206

Steps to reproduce:

test_agent used very old version chai library version=0.5.3
in the current version=1.9.1 deepEqual take prototype into consideration

apps/sms/test/unit/localization_helper_test.js - plain structure

Comment 1

[sv99]

Attachment: Link to PR

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 8492760 [details] [review]
Link to PR

Redirecting to Oleg who knows the localization tests better than me.

Hey Oleg, the goal here is to make the tests ready for updating chai to a newer version. Thanks !

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8492760 [details] [review]
Link to PR

Thanks for the patch! I've left few comments on GitHub.

Please set r? once again when you're ready.

Comment 4

[sv99]

some changed, localization_helper - not beautiful but simple plain and worked! in both chai version lib
Thanks

Comment 5

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8492760 [details] [review]
Link to PR

(In reply to sv99 from comment #4)
> some changed, localization_helper - not beautiful but simple plain and
> worked! in both chai version lib
> Thanks

Thanks! Everything looks good except that I don't really understand necessity of big changes on localization_helper test, left question on github.

Comment 6

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8492760 [details] [review]
Link to PR

Looks like still one review comment isn't answered. Please see it on GitHub, and set r? when you're ready!

Thanks!

Comment 7

[sv99]

Code changed like you want.
Thanks!

Comment 8

[sv99]

Space corrected.

Comment 9

[sv99]

PR rebased

Comment 10

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8492760 [details] [review]
Link to PR

Thanks, looks good now!

Comment 11

[Oleg Zasypkin [:azasypkin]]

Please, r=me in the commit message and add checkin-needed keyword to the bug.

Comment 12

[sv99]

How can i add checkin-needed keyword?

Comment 13

[Oleg Zasypkin [:azasypkin]]

(In reply to sv99 from comment #12)
> How can i add checkin-needed keyword?

There is "Keywords" input at bug page where you can add "checkin-needed" keyword when you got r+, but don't want\can't to land it yourself. 

This time I've just landed it for you, so you don't need "checkin-needed" for this bug, but you can use it in the future :)

Master: https://github.com/mozilla-b2g/gaia/commit/0fcd5d30f298f3a42d7954b2c0cd3e15f245c174

Thanks!