If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Deal with fallout from bug 1050449

RESOLVED FIXED in Firefox 34

Status

SeaMonkey
Autocomplete
--
major
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

unspecified
seamonkey2.33

Firefox Tracking Flags

(firefox34 fixed, firefox35 fixed, firefox36 fixed, seamonkey2.31 fixed, seamonkey2.32 fixed, seamonkey2.33 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Bug 1050449 (landed last cycle) introduce a new toolkit file, toolkit/content/autocomplete.css which gets installed into chrome://global/content/autocomplete.css

However XPFE autocomplete also has an autocomplete.css which gets installed into chrome://global/content/autocomplete.css

Which one gets installed may depend on such factors as which -j value you use, whether you cloned a fresh mozilla-central or updated one from before bug 1050449, or which OS you use.

This is obviously an unhappy state of affairs and we should do something about it. In particular it might block us moving XPFE autocomplete from m-c into suite.

Since Thunderbird has stopped using XPFE autocomplete, we don't have to fight with them and Firefox as to how to proceed here which is a relief.

At the very least I propose we move XPFE autocomplete's content autocomplete.css from global to communicator. We can do this NPOTFB so that it can be uplifted to m-a.

There are a number of additional options but they would probably deserve separate bugs:
a) Moving XPFE autocomplete's skin autocomplete from global to communicator (although the communicator file would simply @import the global file needed for toolkit autocomplete).
b) Moving XPFE autocomplete's XBL binding from global to communicator
c) Moving XPFE autocomplete from m-c to suite
d) Binding XPFE autocomplete in communicator.css instead of xul.css
Flags: needinfo?(philip.chee)
Flags: needinfo?(iann_bugzilla)

Comment 1

3 years ago
> At the very least I propose we move XPFE autocomplete's content
> autocomplete.css from global to communicator. We can do this NPOTFB so that
> it can be uplifted to m-a.
Agreed.

> There are a number of additional options but they would probably deserve
> separate bugs:

> a) Moving XPFE autocomplete's skin autocomplete from global to communicator
> (although the communicator file would simply @import the global file needed
> for toolkit autocomplete).
We should remember to move modern at the same time.

> b) Moving XPFE autocomplete's XBL binding from global to communicator
> c) Moving XPFE autocomplete from m-c to suite
Once we move content css, skin css, and the XBL binding, what's left?

> d) Binding XPFE autocomplete in communicator.css instead of xul.css
Sure.
Flags: needinfo?(philip.chee)
(Assignee)

Comment 2

3 years ago
Created attachment 8501985 [details] [diff] [review]
Proposed patch

OK, so this does step 1 which suffices to unbreak us.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8501985 - Flags: review?(philip.chee)

Updated

3 years ago
Attachment #8501985 - Flags: review?(philip.chee) → review+

Updated

3 years ago
Blocks: 492444
https://hg.mozilla.org/mozilla-central/rev/93802d266a82
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.33
(Assignee)

Comment 4

3 years ago
Comment on attachment 8501985 [details] [diff] [review]
Proposed patch

Approval Request Comment
[Feature/regressing bug #]: 1050449
[User impact if declined]: SeaMonkey autocomplete is broken
[Describe test coverage new/current, TBPL]: N/A
[Risks and why]: Not part of Firefox
[String/UUID change made/needed]: None
Attachment #8501985 - Flags: approval-mozilla-beta?
Attachment #8501985 - Flags: approval-mozilla-aurora?
Comment on attachment 8501985 [details] [diff] [review]
Proposed patch

Given that this will not impact Firefox, I'm approving based on the fact that there is a request for SeaMonkey.
Attachment #8501985 - Flags: approval-mozilla-beta?
Attachment #8501985 - Flags: approval-mozilla-beta+
Attachment #8501985 - Flags: approval-mozilla-aurora?
Attachment #8501985 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/b25b3c530da0
https://hg.mozilla.org/releases/mozilla-beta/rev/78b9d7be1770
status-firefox34: --- → fixed
status-firefox35: --- → fixed
status-firefox36: --- → fixed
status-seamonkey2.31: --- → fixed
status-seamonkey2.32: --- → fixed
status-seamonkey2.33: --- → fixed
(Assignee)

Comment 7

3 years ago
Oops, fix was incomplete.
Status: RESOLVED → REOPENED
status-seamonkey2.31: fixed → affected
status-seamonkey2.32: fixed → affected
status-seamonkey2.33: fixed → affected
Resolution: FIXED → ---
(Assignee)

Comment 8

3 years ago
Created attachment 8518051 [details] [diff] [review]
Additional patch
Attachment #8518051 - Flags: review?(philip.chee)

Comment 9

3 years ago
Comment on attachment 8518051 [details] [diff] [review]
Additional patch

r=me WFM
Attachment #8518051 - Flags: review?(philip.chee) → review+
(Assignee)

Comment 10

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac8de9bcd5d6
(Assignee)

Comment 11

3 years ago
Comment on attachment 8518051 [details] [diff] [review]
Additional patch

Approval Request Comment
[Feature/regressing bug #]: 1050449
[User impact if declined]: SeaMonkey autocomplete is still broken
[Describe test coverage new/current, TBPL]: N/A
[Risks and why]: Not part of Firefox
[String/UUID change made/needed]: None
Attachment #8518051 - Flags: approval-mozilla-beta?
Attachment #8518051 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/ac8de9bcd5d6
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Comment on attachment 8518051 [details] [diff] [review]
Additional patch

Beta+
Aurora+
Attachment #8518051 - Flags: approval-mozilla-beta?
Attachment #8518051 - Flags: approval-mozilla-beta+
Attachment #8518051 - Flags: approval-mozilla-aurora?
Attachment #8518051 - Flags: approval-mozilla-aurora+
status-firefox34: fixed → affected
status-firefox35: fixed → affected
https://hg.mozilla.org/releases/mozilla-aurora/rev/09f6e866b3b4
https://hg.mozilla.org/releases/mozilla-beta/rev/aa474c125c53
status-firefox34: affected → fixed
status-firefox35: affected → fixed
status-seamonkey2.31: affected → fixed
status-seamonkey2.32: affected → fixed
status-seamonkey2.33: affected → fixed

Updated

2 years ago
Flags: needinfo?(iann_bugzilla)
You need to log in before you can comment on or make changes to this bug.