1070768 - Deal with fallout from bug 1050449

Status: RESOLVED FIXED

(SeaMonkey :: Autocomplete, defect)

Description

[[e-mail]]

Bug 1050449 (landed last cycle) introduce a new toolkit file, toolkit/content/autocomplete.css which gets installed into chrome://global/content/autocomplete.css

However XPFE autocomplete also has an autocomplete.css which gets installed into chrome://global/content/autocomplete.css

Which one gets installed may depend on such factors as which -j value you use, whether you cloned a fresh mozilla-central or updated one from before bug 1050449, or which OS you use.

This is obviously an unhappy state of affairs and we should do something about it. In particular it might block us moving XPFE autocomplete from m-c into suite.

Since Thunderbird has stopped using XPFE autocomplete, we don't have to fight with them and Firefox as to how to proceed here which is a relief.

At the very least I propose we move XPFE autocomplete's content autocomplete.css from global to communicator. We can do this NPOTFB so that it can be uplifted to m-a.

There are a number of additional options but they would probably deserve separate bugs:
a) Moving XPFE autocomplete's skin autocomplete from global to communicator (although the communicator file would simply @import the global file needed for toolkit autocomplete).
b) Moving XPFE autocomplete's XBL binding from global to communicator
c) Moving XPFE autocomplete from m-c to suite
d) Binding XPFE autocomplete in communicator.css instead of xul.css

Comment 1

[Philip Chee]

> At the very least I propose we move XPFE autocomplete's content
> autocomplete.css from global to communicator. We can do this NPOTFB so that
> it can be uplifted to m-a.
Agreed.

> There are a number of additional options but they would probably deserve
> separate bugs:

> a) Moving XPFE autocomplete's skin autocomplete from global to communicator
> (although the communicator file would simply @import the global file needed
> for toolkit autocomplete).
We should remember to move modern at the same time.

> b) Moving XPFE autocomplete's XBL binding from global to communicator
> c) Moving XPFE autocomplete from m-c to suite
Once we move content css, skin css, and the XBL binding, what's left?

> d) Binding XPFE autocomplete in communicator.css instead of xul.css
Sure.

Comment 2

[[e-mail]]

Attachment: Proposed patch

OK, so this does step 1 which suffices to unbreak us.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/93802d266a82

Comment 4

[[e-mail]]

Comment on attachment 8501985 [details] [diff] [review]
Proposed patch

Approval Request Comment
[Feature/regressing bug #]: 1050449
[User impact if declined]: SeaMonkey autocomplete is broken
[Describe test coverage new/current, TBPL]: N/A
[Risks and why]: Not part of Firefox
[String/UUID change made/needed]: None

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8501985 [details] [diff] [review]
Proposed patch

Given that this will not impact Firefox, I'm approving based on the fact that there is a request for SeaMonkey.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b25b3c530da0
https://hg.mozilla.org/releases/mozilla-beta/rev/78b9d7be1770

Comment 7

[[e-mail]]

Oops, fix was incomplete.

Comment 8

[[e-mail]]

Attachment: Additional patch

Comment 9

[Philip Chee]

Comment on attachment 8518051 [details] [diff] [review]
Additional patch

r=me WFM

Comment 10

[[e-mail]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac8de9bcd5d6

Comment 11

[[e-mail]]

Comment on attachment 8518051 [details] [diff] [review]
Additional patch

Approval Request Comment
[Feature/regressing bug #]: 1050449
[User impact if declined]: SeaMonkey autocomplete is still broken
[Describe test coverage new/current, TBPL]: N/A
[Risks and why]: Not part of Firefox
[String/UUID change made/needed]: None

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ac8de9bcd5d6

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8518051 [details] [diff] [review]
Additional patch

Beta+
Aurora+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/09f6e866b3b4
https://hg.mozilla.org/releases/mozilla-beta/rev/aa474c125c53

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9d89b054b860
Move XPFE's autocomplete.css to communicator so it doesn't conflict with toolkit's new global autocomplete.css r=Ratty
https://hg.mozilla.org/comm-central/rev/83e7581a608f
Fix up more references to XPFE's autocomplete.css r=Ratty