1070795 - crash in java.lang.NullPointerException: at org.mozilla.search.MainActivity.execute(MainActivity.java)

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-770a7832-a19c-4e17-9374-40a5f2140920.
=============================================================

java.lang.NullPointerException
	at org.mozilla.search.MainActivity.execute(MainActivity.java:283)
	at org.mozilla.search.providers.SearchEngineManager$1.onPostExecute(SearchEngineManager.java:88)
	at android.os.AsyncTask.finish(AsyncTask.java:632)
	at android.os.AsyncTask.access$600(AsyncTask.java:177)
	at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:645)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:157)
	at android.app.ActivityThread.main(ActivityThread.java:5356)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1265)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1081)
	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[:Margaret Leibovic]

Looks like this will happen if suggestionsFragment is null:
http://hg.mozilla.org/mozilla-central/annotate/af668f4b96c8/mobile/android/search/java/org/mozilla/search/MainActivity.java#l283

I suppose this could happen if execute() was called after onDestroy(), but the SearchEngineManager instance is destroyed before suggestionsFragment is set to null, so it shouldn't be calling that execute callback.

I could add a null check around suggestionsFragment (and searchBar), but I'm worried that would just be a band-aid.

Comment 2

[u279076]

I just checked crash-stats and I'm not seeing any reports containing this signature over the last week. Was this inadvertently fixed by another bug?

Comment 3

[:Margaret Leibovic]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #2)
> I just checked crash-stats and I'm not seeing any reports containing this
> signature over the last week. Was this inadvertently fixed by another bug?

It is definitely possible that something else fixed this issue, since this code has changed since this bug was originally filed. I'm not sure what patch deserves credit, but I'm closing this out if we're not seeing any more reports. Please reopen if this comes up again.