Closed Bug 1070797 Opened 5 years ago Closed 5 years ago

crash in java.lang.IllegalArgumentException: mimeType can''t be null at android.app.DownloadManager.validateArgumentIsNonEmpty(DownloadManager.java)

Categories

(Firefox for Android :: Download Manager, defect, critical)

35 Branch
All
Android
defect
Not set
critical

Tracking

()

VERIFIED FIXED
Firefox 35
Tracking Status
firefox35 --- verified
fennec 35+ ---

People

(Reporter: aaronmt, Assigned: wesj)

References

Details

(Keywords: crash, topcrash-android-armv7)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-9ad70c97-a430-4fae-bb63-d21172140920.
=============================================================

java.lang.IllegalArgumentException: mimeType can't be null
	at android.app.DownloadManager.validateArgumentIsNonEmpty(DownloadManager.java:1715)
	at android.app.DownloadManager.addCompletedDownload(DownloadManager.java:1641)
	at android.app.DownloadManager.addCompletedDownload(DownloadManager.java:1629)
	at org.mozilla.gecko.GeckoAppShell.scanMedia(GeckoAppShell.java:1812)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:365)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:186)
Comments suggest this is a startup-crash
#3 on 35 currently
Assignee: nobody → wjohnston
tracking-fennec: ? → 35+
Attached patch PatchSplinter Review
This sets the mimetype to application/octet-stream if we don't know what it is. Apparently other people use application/unknown in that case sometimes. We could try that too. In fact, looking right as I upload this, Chrome tells me that unknown/unknown is also popular.

http://androidxref.com/4.2.2_r1/xref/external/chromium/net/base/mime_sniffer.cc#487

(the comments at the top of that file are interesting). They also do a lot of sniffing here:

http://androidxref.com/4.2.2_r1/xref/external/webkit/Source/WebCore/platform/network/MIMESniffing.cpp#58

but that should be happening in platform (where we have data from the file), not in this Java code.

We should try harder to get the mimetype here. I'll do that in bug 1070099 when I get to it.
Comment on attachment 8495442 [details] [diff] [review]
Patch

Whoops. Never set a review here.
Attachment #8495442 - Flags: review?(margaret.leibovic)
Attachment #8495442 - Attachment is patch: true
Comment on attachment 8495442 [details] [diff] [review]
Patch

Review of attachment 8495442 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable.
Attachment #8495442 - Flags: review?(margaret.leibovic) → review+
This is currently the #5 topcrash in Nightly @ 3.88% and is identified by Socorro as a startup crash.
https://hg.mozilla.org/mozilla-central/rev/a23e44121aa9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Hi, I'm crashing on startup with this signature. I have the very latest nightly (manually downloaded and installed just to make sure). The crashes started the Oct. 3rd after downloading a file (I was also using an up-to-date nightly back then), and now it just crashes less than a second after startup (I guess it's trying to notify the download completion - the file downloaded just fine). I see the UI for half a second before it crashes.

So I think this is not fixed. Or am I seeing another bug? Thank you
Flags: needinfo?(wjohnston)
I don't see any crashes after 2014-10-02-09 so I think we need people to update.
Flags: needinfo?(wjohnston)
Ok, I just updated again and it went away.

I verified the previous update: downloaded from https://nightly.mozilla.org/ yesterday, but it apparently was an old version for some reason (20141002093155). I did the same thing again today and got 20141006030202, which works.

Also at no point I got automatic update offers. I'm not sure people will be getting them if Firefox can't start.

Sorry for the noise.
There were no builds available over the weekend due to build failures, apologies.
I'm marking this bug verified fixed based on crash stats and comment 11. There are still a handful of crashes reported but all of them appear to be people stuck on Fennec 35.0a1.
Status: RESOLVED → VERIFIED
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.