If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Heartbeat doesn't test if redis is writable

RESOLVED FIXED

Status

Hello (Loop)
Server
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: natim, Assigned: natim)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We have because of redis:

    http POST https://loop.services.mozilla.com/registration simplePushURL=http://requestb.in/199uh4b1

    {
      "code": 503, 
      "errno": 201, 
      "error": "Service Unavailable"
    }

Also the heartbeat is fine:

    http GET https://loop.services.mozilla.com/__heartbeat__

    {
      "provider": true, 
      "storage": true
    }
Whiteboard: [qa+]
(Assignee)

Comment 1

3 years ago
Created attachment 8500440 [details] [review]
Link to GitHub PR.
Attachment #8500440 - Flags: review?(tarek)
(Assignee)

Comment 2

3 years ago
https://github.com/mozilla-services/loop-server/commit/79dae6b285c71dfe33efcaa5f725efa164dabe30

However this will need to be tested on Stage.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(rpappalardo)
Flags: needinfo?(dwilson)
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Assignee: nobody → rhubscher

Updated

3 years ago
Attachment #8500440 - Flags: review?(tarek) → review+
(Assignee)

Comment 3

3 years ago
I have verified this on my machine using:

   SLAVEOF localhost 6739

Then the redis-client become read-only.

To get back on:

   SLAVEOF NO ONE
(Assignee)

Comment 4

3 years ago
I have also added a test here: https://github.com/mozilla-services/loop-server/pull/226
(In reply to Rémy Hubscher (:natim) from comment #2)
> https://github.com/mozilla-services/loop-server/commit/
> 79dae6b285c71dfe33efcaa5f725efa164dabe30
> 
> However this will need to be tested on Stage.

Hi Rémy - on localhost I can run redis-cli, but what can I to verify this on stage?
If I understand correctly, you turned off replication with SLAVEOF but then what did you do?  Did you run a command to write directly to redis and see if it would fail?
Flags: needinfo?(rpappalardo) → needinfo?(rhubscher)
(Assignee)

Comment 6

3 years ago
No I accessed the server /__heartbeat__ pages: https://loop.stage.mozaws.net/__heartbeat__
Flags: needinfo?(rhubscher)
https://github.com/mozilla-services/loop-server/commit/cc5d1cb2f622c15222f5104798540bb0578a485b
I assume this can wait for 0.12.5 or 0.12.6...
yes, it will go out with 0.12.6

Updated

3 years ago
Flags: needinfo?(dwilson)
You need to log in before you can comment on or make changes to this bug.