1071105 - potential memory leak in nsDocShell

Status: RESOLVED INVALID

(Core :: DOM: Navigation, defect)

Description

[Tom Tromey :tromey]

I don't have a test case for this; I found it by reading code.

nsDocShell::ClearProfileTimelineMarkers takes care to free the
payload of items in the timeline marker array:

  for (uint32_t i = 0; i < mProfileTimelineMarkers.Length(); ++i) {
    delete mProfileTimelineMarkers[i]->mPayload;
    mProfileTimelineMarkers[i]->mPayload = nullptr;
  }

However, the nsDocShell destructor does not call this or otherwise
free the payloads.

One fix may be to change mPayload to be an nsAutoPtr.

Comment 1

[Tom Tromey :tromey]

https://tbpl.mozilla.org/?tree=Try&rev=4aad0103a0d1

Comment 2

[Tom Tromey :tromey]

Attachment: use nsAutoPtr for InternalProfileTimelineMarker::mPayload

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Don't we call the clear method in Destroy?

Comment 4

[Tom Tromey :tromey]

(In reply to Olli Pettay [:smaug] from comment #3)
> Don't we call the clear method in Destroy?

Darn it, we do, and I missed it, in particular the call to SetRecordProfileTimelineMarkers(false).
I'm sorry for wasting your time.