1071225 - [e10s] FxAccountsOAuthClient.jsm can't close the tab with e10s

Status: VERIFIED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[Matthew N. [:MattN]]

While testing with e10s, alexis was not able to login to Loop at https://accounts.firefox.com/oauth/signin 
The problem may be in WebChannel.jsm or FxAccountsOAuthClient.jsm

Comment 1

[Matthew N. [:MattN]]

I see bug 1061013 disabled browser_fxa_oauth.js so that's probably a good starting place.

Comment 2

[Matthew N. [:MattN]]

INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_fxa_oauth.js | Found an unexpected tab at the end of test run: http://example.com/browser/browser/base/content/test/general/browser_fxa_oauth.html?action=signin&webChannelId=oauth_client_id&client_id=client_id&scope=&state=state - expected PASS

Comment 3

[Matthew N. [:MattN]]

QE should be able to login to FxA via Loop with E10S once this bug is fixed.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Matt, thanks for filing? Mind fixing it too?

Comment 5

[Vlad Filippov (:vladikoff)]

Matt, I can take a look at this if you are busy with other stuff / don't have a patch in progress

Comment 6

[Matthew N. [:MattN]]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #4)
> Matt, thanks for filing? Mind fixing it too?

I was hoping Vlad would volunteer because he's awesome like that :) I haven't started on this yet.

Comment 7

[Vlad Filippov (:vladikoff)]

The good news - authentication actually works and Loop logs in. The bad news - it cannot close the tab.

Comment 8

[Matthew N. [:MattN]]

OK, updating the summary.

Comment 9

[Vlad Filippov (:vladikoff)]

Attachment: 0001-Bug-1071225-Fixes-FxA-OAuth-to-work-properly-with-e1.patch

Enabling e10s testing for this module.

Comment 10

[Matthew N. [:MattN]]

Comment on attachment 8494174 [details] [diff] [review]
0001-Bug-1071225-Fixes-FxA-OAuth-to-work-properly-with-e1.patch

Review of attachment 8494174 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! This looks good to me.

I'll push this later as I've run both kinds of tests locally and did manual testing in E10S and non-E10S mode.

Comment 11

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/1105c83a13bf

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1105c83a13bf

Comment 13

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce the "login" issue from Comment 0 "alexis was not able to login to Loop". I used Nightly 35.0a1 (2014-09-24) on Windows 7 x64 and I accessed the Loop pop-up where I selected the Sign-in link. I was redirected to https://accounts.firefox.com/oauth/signin?webChannelId=oauth_a8b39c2b1cab722e&client_id=a8b39c2b1cab722e&scope=profile&state=156c86df721168ae76d1f7e4ac88b369b34e15a51381e118e71f57f51d225833 page and here is the place where I was unable to login.

The link from Comment 0 https://accounts.firefox.com/oauth/signin is the page where the user logs-in to Firefox Account, which on the other hand works fine. Actually logging to this page does not log the user to Loop.
The Tab issue from Comment 7 "bad news - it cannot close the tab" I was unable to reproduce it, all tabs closing successfully.
Vlad can you please clarify me a little bit since you have reproduced the tab issue? Right now I am not sure which is the bug here.

Vlad, if "close tabs" is really the issue here can you please verify if it is fixed since I was unable to reproduce that part.

Comment 14

[Vlad Filippov (:vladikoff)]

(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #13)
> I was able to reproduce the "login" issue from Comment 0 "alexis was not
> able to login to Loop". I used Nightly 35.0a1 (2014-09-24) on Windows 7 x64
> and I accessed the Loop pop-up where I selected the Sign-in link. I was
> redirected to
> https://accounts.firefox.com/oauth/
> signin?webChannelId=oauth_a8b39c2b1cab722e&client_id=a8b39c2b1cab722e&scope=p
> rofile&state=156c86df721168ae76d1f7e4ac88b369b34e15a51381e118e71f57f51d225833
> page and here is the place where I was unable to login.
> 
> The link from Comment 0 https://accounts.firefox.com/oauth/signin is the
> page where the user logs-in to Firefox Account, which on the other hand
> works fine. Actually logging to this page does not log the user to Loop.
> The Tab issue from Comment 7 "bad news - it cannot close the tab" I was
> unable to reproduce it, all tabs closing successfully.
> Vlad can you please clarify me a little bit since you have reproduced the
> tab issue? Right now I am not sure which is the bug here.
> 
> Vlad, if "close tabs" is really the issue here can you please verify if it
> is fixed since I was unable to reproduce that part.

Sorry this bug is from September and was resolved. I'm really confused why are you testing it in Nightly 35.0a1 (2014-09-24). Let me know.

Comment 15

[Vasilica Tamas, QA [:vtamas]]

(In reply to Vlad Filippov from comment #14)

> Sorry this bug is from September and was resolved. I'm really confused why
> are you testing it in Nightly 35.0a1 (2014-09-24). Let me know.

I was trying to reproduce this issue in order to verify it on latest Nightly.

I do not know exactly what should I verify because the summary of this bug was changed and I managed to reproduce only the first version "Summary: [e10s] FxA OAuth login doesn't work with e10s".

Comment 16

[Cornel Ionce [:noni] [Hubs QA]]

I was able to reproduce the issue mentioned in comment 7 using the 2014-09-24 Nightly on Ubuntu 12.04 32-bit.

Confirming the fix on latest Nightly, build ID: 20141230030214 on Ubuntu 12.04 32-bit, Windows 7 64-bit and Mac OS X 10.9.5.