Clear/reset the classification textbox and dropdown when the Save button is clicked.

RESOLVED FIXED

Status

Tree Management
Treeherder
P1
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: KWierso, Assigned: camd)

Tracking

Details

(Reporter)

Description

4 years ago
If I type some reason into the classification textbox for a pinned job and hit "Save" to submit it to the database (and at the moment, TBPL), the job details panel disappears from view. If I then select another job and pin it, the previous contents of the classification textbox is still in there, so I have to manually clear it out before typing anything else in there. 

Similarly, when I select one of the other options in the classification dropdown, save the classification, then move on to another job, that previously-selected option is still selected, and I have to manually change it back to "intermittent".

IMO, I shouldn't have to do this manually, and treeherder should just clear the textbox and reselect "intermittent" from the dropdown whenever I click the "Save" button (or whenever some callback from the "Save" button returns successfully, if there is such a callback).

Updated

4 years ago
Blocks: 1059400
Priority: -- → P1

Updated

4 years ago
Blocks: 1059368
(Assignee)

Updated

4 years ago
Assignee: nobody → cdawson
Status: NEW → ASSIGNED

Comment 2

4 years ago
Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/b590c4e4b5e0f8fd8abc1d882e110920debe8116
Merge pull request #201 from mozilla/bug-1071240-clear-classification-on-save

bug 1071240 - clear classification on save.
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 3

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/37e95ff29ed22c4bcc993fbc4658481063210d6e
bug 1071240 - clear classification on save.

https://github.com/mozilla/treeherder/commit/d95d14dd0564dd9cd9478c6db80fe4bf6fb7427b
Merge pull request #201 from mozilla/bug-1071240-clear-classification-on-save

bug 1071240 - clear classification on save.
You need to log in before you can comment on or make changes to this bug.