1071249 - Create cron job for expired tasks

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect, P1)

Description

[Bob Silverberg [:bsilverberg]]

We need a cron job to run the expired tasks expiration check, which will automatically close attempts for tasks that have expired.

Comment 2

[Bob Silverberg [:bsilverberg]]

This is a separate cron job, which is why I opened a separate bug. There are two tasks to set up two different cron jobs, and one can be done now (this one), and one cannot be done until a bug 1033808 is resolved.

Comment 3

[Bob Silverberg [:bsilverberg]]

I went back and looked at the code we currently have, and it does 1 thing:

For any attempts that have been open for more than 30 days, which are for *one-time* tasks, it will close the attempt.

Do we also want a job that will close any open attempts for tasks that have expired (i.e., the task itself has an end date which is now past) for all tasks (whether one-time or repeatable)?

I guess the question is: What should happen if a user has an open attempt and the task itself expires (i.e., its end date is now in the past)? Should that attempt be closed and the user informed, or should it just remain open?

Comment 4

[Rebecca Billings [:rbillings]]

Yes, we need a job that will close all tasks that have passed their end date & notify the user the next time they log in.

Comment 5

[Bob Silverberg [:bsilverberg]]

Commit pushed to master at https://github.com/mozilla/oneanddone

https://github.com/mozilla/oneanddone/commit/c571551df4751e2d9a730d9898fd56ba180fd226
Bug 1071249 - Create cron job for expired tasks

Add routine to close attempts for expired tasks

Comment 6

[Bob Silverberg [:bsilverberg]]

This has landed and will be pushed to dev and stage later today. We can discuss verification for this tomorrow.

Comment 7

[Rebecca Billings [:rbillings]]

Just let me know when it's up on dev/stage & I'll get on it.

Comment 8

[Bob Silverberg [:bsilverberg]]

Sorry, Rebecca, this landed on dev and stage some time ago.

Comment 9

[Rebecca Billings [:rbillings]]

I see that tasks past their end date immediately serve the expired/invalid notice- is that from the cron job? How often does it run?

Comment 10

[Bob Silverberg [:bsilverberg]]

If you update a task and thereby cause it to expire that will automatically close the attempts, so that is likely what you're seeing. Let's talk tomorrow about how to test the background task. FTR, it currently runs every hour, but I think we should reduce that to every 6 hours or so.

Comment 11

[Rebecca Billings [:rbillings]]

Verified on staging, all tasks with expiration date in the past were marked as closed.