[Camera] Camera settings icon looks incorrect

RESOLVED INVALID

Status

Firefox OS
Gaia::Camera
P1
normal
RESOLVED INVALID
3 years ago
3 years ago

People

(Reporter: amylee, Assigned: ivanovpavel)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: ux-tracking, visual design)

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8493340 [details]
Camera_Settings_Icon.png

Hi, 

The camera settings icon looks thicker than it should be (see attached screen comparison). Also attached the settings.svg icon.
(Reporter)

Comment 1

3 years ago
Created attachment 8493342 [details]
Options.svg
Created attachment 8494289 [details] [review]
patch for gaia-icons/master

Hey Amy this will affect all 'menu' icons, are you OK with this one?
Attachment #8494289 - Flags: review?(wilsonpage)
Comment on attachment 8494289 [details] [review]
patch for gaia-icons/master

Looks good to me, I'll land it when Amy gives the go ahead. We'll need a second patch for Gaia to update gaia-icons too. This is going to be a little trickier than normal as I have introduced breaking change since it was last updated.

I changed the name and API of the JS font loader (gaia-icons.js). This means we'll need to update gaia-header to the latest version. I don't mind taking care of the Gaia patch :)

No more breaking changes after this, promise!
Attachment #8494289 - Flags: review?(wilsonpage) → review+
(Reporter)

Comment 4

3 years ago
Comment on attachment 8494289 [details] [review]
patch for gaia-icons/master

Hi Pavel, 

I don't want the icon change to affect the rest of the headers in the OS so please leave it as is. Thank you for your efforts on this.
Ok :) I will close this one
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.