1071266 - [flame] XCode 6 only provides 10.9 SDK causing flame builds to fail

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Eric Rahm [:erahm]]

I upgraded to xcode 6.0.1 which no longer provides a suitable SDK for flame development. This is a pretty big issue, I can no longer build and others on #b2g are reporting the same issue.

I get the following error:
> "** Don't have a product spec for: 'flame'"

I manually added 10.9 to the supported SDK list in |build/core/combo/HOST_darwin-x86.mk|, this gets me further to the following error:

> "system/core/include/log/log.h:38:20: error: stdarg.h: No such file or directory"

Comment 1

[Eric Rahm [:erahm]]

Modifying the if(10.8) use other stdarg.h block to specify 10.9 in |build/core/combo/HOST_darwin-x86.mk| seems to fix my build issues.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch

this patch seems to fix it for 10.9

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8493381 [details] [diff] [review]
patch

changing request to dhylands to load balance review requests

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

FYI, I was able to build by downloading the 10.8 SDK, analogously to the 10.6 SDK download instructions[1].

Basically, you download XCode 5.1.1 from the Apple Developer downloads site, use Pacifist to extract the 10.8 SDK, then symlink the SDK location to /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/ .

[1] https://developer.mozilla.org/en-US/Firefox_OS/Firefox_OS_build_prerequisites#Making_the_Mac_OS_X_10.6_SDK_available

Comment 5

[Dave Hylands [:dhylands]]

Comment on attachment 8493381 [details] [diff] [review]
patch

Review of attachment 8493381 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not familiar with Mac stuff and can't test this, but having said that, this looks like a reasonable patch.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/platform_build/commit/548d54bda5582feaf0e179d40ac48be56292864d
Merge: https://github.com/mozilla-b2g/platform_build/commit/3a2947df41a480de1457a6dcdbf46ad0af70d8e0

I merged it into b2g-4.4.2 branch, not sure what master is, but we seem to be using that one.

Comment 7

[Dave Hylands [:dhylands]]

So we use different branches depending on which base version of android is being used.

If you cd into B2G/.repo/manifests and do

grep platform_build *.xml

then this will show the branches used for each device.

4.4.2 only covers the flame-kk device.

mwu knows which repositories we can land stuff in and which we can't, so I'd double check with him.
I'll ni him.

Comment 9

[Michael Wu [:mwu]]

That looks fine.

b2g-4.4.2 also covers emulator-kk.

Comment 10

[Jet Villegas (inactive)]

A fresh git clone git://github.com/mozilla-b2g/B2G.git and ./config.sh flame doesn't seem to be pulling down this code. 

https://developer.mozilla.org/en-US/Firefox_OS/Building_and_installing_Firefox_OS/Building_Firefox_OS_for_flame_on_OSX

Comment 11

[Dave Hylands [:dhylands]]

(In reply to Jet Villegas (:jet) from comment #10)
> A fresh git clone git://github.com/mozilla-b2g/B2G.git and ./config.sh flame
> doesn't seem to be pulling down this code. 
> 
> https://developer.mozilla.org/en-US/Firefox_OS/
> Building_and_installing_Firefox_OS/Building_Firefox_OS_for_flame_on_OSX

You'd need to use ./config.sh flame-kk

Using flame builds flame using a jelly-bean base. flame-kk builds flame using a kit-kat base.