talos_from_code.py should allow custom .zips from ash project, throw a sensible error when talos.zip comes from bad location

RESOLVED FIXED

Status

Release Engineering
Mozharness
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It would be handy to allow custom talos .zips (for Android testing) from the ash branch. Also, the error we currently print when downloading a resource from an invalid location when running on an unsupported branch (e.g. ash currently, mozilla-central) triggers a python exception.
Created attachment 8493429 [details] [diff] [review]
Allow ash, fix exception
Attachment #8493429 - Flags: review?(kmoir)

Comment 2

3 years ago
If this now allows custom zips on ash, would you mind updating the docs at https://wiki.mozilla.org/Buildbot/Talos/Running#Testing_on_Try_Server that jmaher created recently in bug 1054211? :-)

Updated

3 years ago
Status: NEW → ASSIGNED

Updated

3 years ago
Attachment #8493429 - Flags: review?(kmoir) → review+
(In reply to Ed Morley [:edmorley] from comment #2)
> If this now allows custom zips on ash, would you mind updating the docs at
> https://wiki.mozilla.org/Buildbot/Talos/Running#Testing_on_Try_Server that
> jmaher created recently in bug 1054211? :-)

.zips from foreign locations being disallowed isn't really covered in this documentation. I honestly don't think it's worth mentioning there, as I think it's just unnecessary information that's going to confuse people. Almost no one tests talos .zip's (it's an Android only thing) and it's a given that works on try branches.
Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/f294836b305b
https://hg.mozilla.org/mozilla-central/rev/f294836b305b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.