1071339 - Improvements to STRONG_GLENUM's

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Improve STRONG_GLENUM

This builds on the work from bug 1063053 and hopefully stays true to its original spirit while bringing some improvements to STRONG_GLENUM's:
 * minimize the size of macros.
 * wrap enum values in a STRONG_GLENUM_VALUE(X) macro so we could extend this easily (e.g. stringifying or static-checking things).
 * assert that enum values are listed in order, which allows for binary search, which might be appreciable even as it's only used in debug builds at the moment, as the TexInternalFormat enum is going to have 80 values...!
 * in debug builds, initialize with a dummy bad value and assert that it isn't the current value anymore by the time we read it.
 * allow GLenums on either side of == and !=  (ran into that problem while using this for TexInternalFormat).

Comment 1

[u480271]

Comment on attachment 8493449 [details] [diff] [review]
Improve STRONG_GLENUM

Review of attachment 8493449 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with Inexistant changed to Nonexistant.

::: dom/canvas/WebGLStrongTypes.h
@@ +97,5 @@
> +template<typename Details>
> +class StrongGLenum MOZ_FINAL
> +{
> +private:
> +    static const GLenum InexistantGLenum = 0xdeaddead;

English would say "NonexistantGLenum"

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7dcea476fca

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f7dcea476fca