Closed Bug 1071340 Opened 5 years ago Closed 5 years ago

Convert to STRONG_GLENUM: TexType, TexFormat, TexInternalFormat

Categories

(Core :: Canvas: WebGL, defect)

Other Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: bjacob, Assigned: bjacob)

References

Details

Attachments

(1 file)

WebGL1 had the nice property that format==internalformat in texImage2D.

That's no longer true in WebGL2. So now we need to go over our code and differentiate what should be format from what should be internalformat. The only way that I know to reason about it is by stronger typing; fortunately we have STRONG_GLENUMs.
Attachment #8493450 - Flags: review?(dglastonbury)
Attachment #8493450 - Flags: review?(dglastonbury) → review+
https://hg.mozilla.org/mozilla-central/rev/ab0360ef35a3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.