Convert to STRONG_GLENUM: TexType, TexFormat, TexInternalFormat

RESOLVED FIXED in mozilla35

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

(Blocks: 1 bug)

Other Branch
mozilla35
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 8493450 [details] [diff] [review]
Convert texture format enums to STRONG_GLENUMs

WebGL1 had the nice property that format==internalformat in texImage2D.

That's no longer true in WebGL2. So now we need to go over our code and differentiate what should be format from what should be internalformat. The only way that I know to reason about it is by stronger typing; fortunately we have STRONG_GLENUMs.
Attachment #8493450 - Flags: review?(dglastonbury)
Attachment #8493450 - Flags: review?(dglastonbury) → review+
Blocks: 1071233
https://hg.mozilla.org/mozilla-central/rev/ab0360ef35a3
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.