1071359 - Make WebRTC on B2G uses logcat as logging sub-system

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Changbin Park]

WebRTC on B2G has its own logging module and it shows output in file(s) or nspr, same as Android.
B2G uses logcat from Android as its logging sub-system and it'll be helpful that seeing logs from WebRTC as mixed with logs from other messages.

Comment 1

[Changbin Park]

Attachment: Use webrtc::LogcatTraceContext as callback of the webrtc::Trace.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8493532 [details] [diff] [review]
Use webrtc::LogcatTraceContext as callback of the webrtc::Trace.

Review of attachment 8493532 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!  nspr works, but is far from preferable for this

Comment 3

[Changbin Park]

Build result looks fine.
https://tbpl.mozilla.org/?tree=Try&rev=5011e40e1e81

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

Note that NSPR logging output is to logcat on B2G by default. It's just a matter of setting the NSPR_LOG_MODULES environment variable to whatever modules need to be enabled and leave the NSPR_LOG_FILE variable empty.

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

Note that NSPR logging output is redirected to logcat on B2G by default. It's just a matter of setting the NSPR_LOG_MODULES environment variable to whatever modules need to be enabled and leave the NSPR_LOG_FILE variable empty.

Comment 6

[Changbin Park]

(In reply to Gabriele Svelto [:gsvelto] from comment #5)
> Note that NSPR logging output is redirected to logcat on B2G by default.
> It's just a matter of setting the NSPR_LOG_MODULES environment variable to
> whatever modules need to be enabled and leave the NSPR_LOG_FILE variable
> empty.
Thanks for comment. That's the way I used to.
But, messages from WEBRTC_TRACE macros are not shown in logcat log.
So, I feel it's not that convenient. Because I have to choose a file or stderr for message output channel.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/088fc2a2dfb9

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/088fc2a2dfb9

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This patch uses 8 MB of memory per process on b2g.  Reverted.

https://hg.mozilla.org/mozilla-central/rev/7c24470b6b3a

Comment 10

[Changbin Park]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #9)
> This patch uses 8 MB of memory per process on b2g.  Reverted.
I checked that memory size in RSS is differ by less than 2MB per process but it's not that much.
Would you please tell me how to get it?

Comment 11

[BMO Automation]

Firefox OS is not being worked on