Closed Bug 1071359 Opened 7 years ago Closed 4 years ago

Make WebRTC on B2G uses logcat as logging sub-system

Categories

(Firefox OS Graveyard :: General, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX
2.1 S6 (10oct)

People

(Reporter: pchangbin, Assigned: pchangbin)

Details

Attachments

(1 file)

WebRTC on B2G has its own logging module and it shows output in file(s) or nspr, same as Android.
B2G uses logcat from Android as its logging sub-system and it'll be helpful that seeing logs from WebRTC as mixed with logs from other messages.
Comment on attachment 8493532 [details] [diff] [review]
Use webrtc::LogcatTraceContext as callback of the webrtc::Trace.

Review of attachment 8493532 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!  nspr works, but is far from preferable for this
Attachment #8493532 - Flags: review?(rjesup) → review+
Build result looks fine.
https://tbpl.mozilla.org/?tree=Try&rev=5011e40e1e81
Keywords: checkin-needed
Assignee: nobody → pchangbin
Note that NSPR logging output is redirected to logcat on B2G by default. It's just a matter of setting the NSPR_LOG_MODULES environment variable to whatever modules need to be enabled and leave the NSPR_LOG_FILE variable empty.
(In reply to Gabriele Svelto [:gsvelto] from comment #5)
> Note that NSPR logging output is redirected to logcat on B2G by default.
> It's just a matter of setting the NSPR_LOG_MODULES environment variable to
> whatever modules need to be enabled and leave the NSPR_LOG_FILE variable
> empty.
Thanks for comment. That's the way I used to.
But, messages from WEBRTC_TRACE macros are not shown in logcat log.
So, I feel it's not that convenient. Because I have to choose a file or stderr for message output channel.
https://hg.mozilla.org/mozilla-central/rev/088fc2a2dfb9
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
This patch uses 8 MB of memory per process on b2g.  Reverted.

https://hg.mozilla.org/mozilla-central/rev/7c24470b6b3a
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 2.1 S5 (26sep) → 2.1 S6 (10oct)
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #9)
> This patch uses 8 MB of memory per process on b2g.  Reverted.
I checked that memory size in RSS is differ by less than 2MB per process but it's not that much.
Would you please tell me how to get it?
Firefox OS is not being worked on
Status: REOPENED → RESOLVED
Closed: 7 years ago4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.