107140 - Tab height in Classic too small for loading animation

Status: RESOLVED WORKSFORME

(SeaMonkey :: Themes, defect)

Description

[wleese]

When opening a page in a tab the tab (/tab menubar) itself is resized when the
loading animation appears. This is especially visible on slow machines.

expected result: the tabs and tabs menubar should at all time maintain the same
heigh.

This is correctly done in the modern skin.

Comment 1

[Joonas]

I'm using Windows 2000, build id 2002020409 and I don't see the loading
animation (in classic) at all. The menubar doesn't resize, nothing happens until
the page loads (and the icon appears). While loading, no animation, no icon, no
nothing. Works ok in modern.

Comment 2

[Joonas]

Attachment: this should fix it

browser.css talks about "chrome://global/skin/loading.gif" which doesn't exist.
My patch changes that to "chrome://communicator/skin/icons/loading.gif", which
seems to do the trick. Woo-hoo. 

One strange thing though. After applying the patch, the first time the
animation is loaded it has a white background for a while. The white stuff
disappears almost instantly. A known bug, I'm sure.

This is my first stab at Patch maker (thanks, Gerv), so be gentle with me if I
did something wrong and trashed someone's system or something.

(btw, this is probably an outdated bug that should be worksforme'd and a new
bug should be filed about not seeing the animation at all and this patch should
be attached to that bug but... :)

Comment 3

[Joonas]

Attachment: oops. wrong file.

I read the fine manual (http://www.mozilla.org/hacking/patch-maker/) and it
seems to suggest that it is the .diff file I should send, not the .chromediff
one. Oops. Hope this one works. Well, the fix is simple enough so there should
be no problems in understanding what should be changed and where :)

Btw, I can't see the loading animation in the 0.9.8 release.

Comment 4

[Joonas]

I found bug 123757 which is about not showing the loading animations at all
(didn't exist when I commented on this bug). I'll attach my patch there. Please
ignore everything I said here. Sorry for trying to morph this bug.

Comment 5

[Joonas]

I'm on a Debian 2.2 machine with Mozilla 0.9.7 (build id: 2001122815, don't have
access to a newer build now but I'm quite sure this hasn't regressed after this
build) and the loading animation is normal.

That means, no menubar resizing when the loading animation appears. In other
words, this WORKSFORME.

Reporter, do you still see this problem on newer builds?

Comment 6

[Keyser Sose]

Marking NEW. Jonas you should contact the correct owner on this list
http://www.mozilla.org/owners.html and get a review/sr for the patch to be
checked in. 

Comment 7

[Joonas]

Linux build 2002032808 - still can't reproduce this (tab bar doesn't resize). I
think this is WFM.

Keyser: you marked this NEW, does that mean that you can reproduce this?

Reporter ([e-mail]): can you still reproduce this on newer builds?

Comment 8

[Keyser Sose]

Yeah but it  was so long ago i dont really remember it. Also i got a faster
machine these days so I cant really test it (oh well :)

Comment 9

[Daniel Wang]

no response from reporter -> wfm