Make client.mk detect python like configure and mach do

RESOLVED FIXED in Firefox 33

Status

defect
RESOLVED FIXED
5 years ago
Last year

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla35

Firefox Tracking Flags

(firefox33 fixed, firefox34 fixed, firefox35 fixed)

Details

Attachments

(1 attachment)

This is kind of the same as bug 957721, but for client.mk, and fixes problems
on seamonkey windows builders, where python is not python 2.7.
Attachment #8493545 - Flags: review?(mshal) → review+
Justin, can you tell me what trees you'd need that backported to? And, more importantly, if that solves your seamonkey problems on windows.
Flags: needinfo?(bugspam.Callek)
https://hg.mozilla.org/mozilla-central/rev/d62a8389ca0a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
(In reply to Mike Hommey [:glandium] from comment #2)
> Justin, can you tell me what trees you'd need that backported to? And, more
> importantly, if that solves your seamonkey problems on windows.

Thanks, it does seem to be helping, we'd like it on aurora and beta as well please.
Flags: needinfo?(bugspam.Callek)
Comment on attachment 8493545 [details] [diff] [review]
Make client.mk detect python like configure and mach do

Approval Request Comment
[Feature/regressing bug #]: This helps some strangely configured build environments building
[User impact if declined]: e.g. Seamonkey automation has a hard time building on Windows because of their environment.
[Describe test coverage new/current, TBPL]: Landed near a week ago on m-i.
[Risks and why]: Low. This is a change to one of the first things the build system does. It only impacts what python is used to run a python command in client.mk, which, in itself has no influence on what python is going to be used during the build. This uses the same trick that mach has been using for weeks if not months, and if it had caused problems, we'd have heard about them already because the build would just start to build with infinite parallel jobs, which would put any machine trying to do that to a halt.
[String/UUID change made/needed]: None
Attachment #8493545 - Flags: approval-mozilla-beta?
Attachment #8493545 - Flags: approval-mozilla-aurora?
Attachment #8493545 - Flags: approval-mozilla-beta?
Attachment #8493545 - Flags: approval-mozilla-beta+
Attachment #8493545 - Flags: approval-mozilla-aurora?
Attachment #8493545 - Flags: approval-mozilla-aurora+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.