Closed Bug 1071445 Opened 8 years ago Closed 8 years ago

[Settings]Fix Cap letter for titles on panels based on new Building Blocks

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S6 (10oct)

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

(Whiteboard: [p=1])

Attachments

(3 files)

To follow new Building Block
Assignee: nobody → gasolin
WIP
Comment on attachment 8493561 [details] [review]
pull request redirect to github

quick sort titles to fit for building block guide
Attachment #8493561 - Flags: review?(ejchen)
Attached image BB writing style
attach BB writing style for reference
Fred, after thinking for a while, even though we landed this bug, there would be still lots of places needs to be fixed. 

So I think maybe we can make bug as a meta bug and ask UX to file different bugs (by panel would be nice) with clear instructions about which should be capitalized and which shouldn't. In this way, we can have UX to verify the modified result at the same time.

And also, these bugs can be good-first bug too if people want to jump in to help.

What do you think (?
Flags: needinfo?(gasolin)
Ya I'm fine with it. And I'm glad to mentor those good-first bugs.

ni @jenny,
once you feel ready to find out all Cap letter related issues, please fire bugs per panel.
Flags: needinfo?(gasolin) → needinfo?(jelee)
Summary: [Settings]Cap letter for titles on root panel → [META][Settings]Cap letter for titles on panels
per discussion offline with EJ, we will try to fix general bugs, set UX review and land this issue.

Then tracking followup UI good-first bugs in bug 1073341.
Blocks: 1073341
Summary: [META][Settings]Cap letter for titles on panels → [Settings]Fix Cap letter for titles on panels based on new Building Blocks
Comment on attachment 8493561 [details] [review]
pull request redirect to github

Help to set ui-review? on Jenny for this patch.

@Jenny, if you need any help about how to flash patched to your device, please feel free to ask us for help :)

I'll pass this review to UX and once ui-review+, this patch would automatically get review+ from me.

Thanks !!
Attachment #8493561 - Flags: ui-review?(jelee)
Comment on attachment 8493561 [details] [review]
pull request redirect to github

Hi Ej,it seems on landing page, Media "storage" is not title case. There are still a few titles that needs fixing in some of the panels, especially the ones on 2nd or deeper layers. Per discussion, let's go through the items and post them on meta bug, the goal is to get all of them in 2.2. Thank you ;)
Attachment #8493561 - Flags: ui-review?(jelee) → ui-review+
Flags: needinfo?(jelee)
Comment on attachment 8493561 [details] [review]
pull request redirect to github

as EJ's comment, carry r+ from jenny.

fixed Media 'storage' bug. merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/cb7d861d7c9afbde096071c4760301ba059b309e
Attachment #8493561 - Flags: review?(ejchen)
Thanks jenny! Please fire those sub-items' bugs and link them on meta bug 1073341,

Then we could set those bugs as good-first bug and mentor new contributors to fix them all in 2.2.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S6 (10oct)
Unfortunately I've had to revert this due to Gij failures. These failures are not your fault, and are masked by bug 1075787.

Here is an example of the failure: https://tbpl.mozilla.org/php/getParsedLog.php?id=49178155&tree=B2g-Inbound

https://github.com/mozilla-b2g/gaia/commit/c4e92ac6ad0b5fdee234424acd6d1a9b99d5693f
Status: RESOLVED → REOPENED
Flags: needinfo?(gasolin)
Resolution: FIXED → ---
I think this is because of the 'Create Account or Sign In' string changing. Note that it's bad practice to have hardcoded strings like this, and would be better to use an l10n helper to parse the properties file and extract the expected string based on key.

Here is the original commit + a patch which may address the failing test. Let's wait to see what gaia-try says, and if it looks good we can land this as a fix.
I think my attachment above and test fix should handle this. We can land it after the tree re-opens.
Flags: needinfo?(gasolin)
I've relanded this for you with the test fix: https://github.com/mozilla-b2g/gaia/commit/e613c173666360a54c29bfb045acc556eeeb2c36
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.