1071445 - [Settings]Fix Cap letter for titles on panels based on new Building Blocks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

To follow new Building Block

Comment 1

[[e-mail]]

Attachment: pull request redirect to github

WIP

Comment 2

[[e-mail]]

Comment on attachment 8493561 [details] [review]
pull request redirect to github

quick sort titles to fit for building block guide

Comment 3

[[e-mail]]

Attachment: BB writing style

attach BB writing style for reference

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Fred, after thinking for a while, even though we landed this bug, there would be still lots of places needs to be fixed. 

So I think maybe we can make bug as a meta bug and ask UX to file different bugs (by panel would be nice) with clear instructions about which should be capitalized and which shouldn't. In this way, we can have UX to verify the modified result at the same time.

And also, these bugs can be good-first bug too if people want to jump in to help.

What do you think (?

Comment 5

[[e-mail]]

Ya I'm fine with it. And I'm glad to mentor those good-first bugs.

ni @jenny,
once you feel ready to find out all Cap letter related issues, please fire bugs per panel.

Comment 6

[[e-mail]]

per discussion offline with EJ, we will try to fix general bugs, set UX review and land this issue.

Then tracking followup UI good-first bugs in bug 1073341.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8493561 [details] [review]
pull request redirect to github

Help to set ui-review? on Jenny for this patch.

@Jenny, if you need any help about how to flash patched to your device, please feel free to ask us for help :)

I'll pass this review to UX and once ui-review+, this patch would automatically get review+ from me.

Thanks !!

Comment 8

[Jenny Lee]

Comment on attachment 8493561 [details] [review]
pull request redirect to github

Hi Ej,it seems on landing page, Media "storage" is not title case. There are still a few titles that needs fixing in some of the panels, especially the ones on 2nd or deeper layers. Per discussion, let's go through the items and post them on meta bug, the goal is to get all of them in 2.2. Thank you ;)

Comment 9

[[e-mail]]

Comment on attachment 8493561 [details] [review]
pull request redirect to github

as EJ's comment, carry r+ from jenny.

fixed Media 'storage' bug. merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/cb7d861d7c9afbde096071c4760301ba059b309e

Comment 10

[[e-mail]]

Thanks jenny! Please fire those sub-items' bugs and link them on meta bug 1073341,

Then we could set those bugs as good-first bug and mentor new contributors to fix them all in 2.2.

Comment 11

[Kevin Grandon :kgrandon]

Unfortunately I've had to revert this due to Gij failures. These failures are not your fault, and are masked by bug 1075787.

Here is an example of the failure: https://tbpl.mozilla.org/php/getParsedLog.php?id=49178155&tree=B2g-Inbound

https://github.com/mozilla-b2g/gaia/commit/c4e92ac6ad0b5fdee234424acd6d1a9b99d5693f

Comment 12

[Kevin Grandon :kgrandon]

Attachment: Pull request - reland with test fix

I think this is because of the 'Create Account or Sign In' string changing. Note that it's bad practice to have hardcoded strings like this, and would be better to use an l10n helper to parse the properties file and extract the expected string based on key.

Here is the original commit + a patch which may address the failing test. Let's wait to see what gaia-try says, and if it looks good we can land this as a fix.

Comment 13

[Kevin Grandon :kgrandon]

I think my attachment above and test fix should handle this. We can land it after the tree re-opens.

Comment 14

[Kevin Grandon :kgrandon]

I've relanded this for you with the test fix: https://github.com/mozilla-b2g/gaia/commit/e613c173666360a54c29bfb045acc556eeeb2c36