107148 - chatzilla menus should move to an overlay

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[nnooiissee]

rginda specified menu-overlay.xul for them.

Comment 1

[nnooiissee]

Attachment: menu-overlay.xul

Comment 2

[nnooiissee]

Attachment: diff of chatzilla.xul

Comment 3

[nnooiissee]

i just ripped out over half of chatzilla.xul. please double check me before
applying.

also, is there anything else that should go into menu-overlay.xul? anything i
pulled that i should not have?

this might be only a first step. chatzilla.dtd to menu-overlay.dtd might be good
too, and maybe even handlers.js to menu-overlay.js?


i think this is a very good thing. this makes chatzilla.xul much more
manageable, and, well, puts alot of crap into menu-overlay.xul... but even that
should be more manageable now.

Comment 4

[Chase Tingley]

NEW

Comment 5

[Robert Ginda]

I'm doing a similar thing with venkman, and I agree it is a worthwhile fix. 
I'll merge this to the branch (after picking some minor nits.)

I'm not sure why the patchmaker bug was added to this, the patch is already done.

Comment 6

[Robert Ginda]

on branch.

Comment 7

[Robert Ginda]

The chatzilla 0.8.5 branch has landed, if you believe this bug is not actually
fixed, and you are sure you are running chatzilla 0.8.5-rc1, please reopen the
bug for further consideration.

Comment 8

[[e-mail]]

Oops, looks like I mistyped the checkin comment for bug 107418 as bug 107148 :-(