Enable async PlacesTransactions in Nightly

RESOLVED FIXED in Firefox 56

Status

()

defect
P1
normal
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: mano, Assigned: standard8)

Tracking

(Depends on 1 bug, Blocks 3 bugs, {perf})

unspecified
Firefox 56
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [qf:meta][fxsearch])

Attachments

(1 attachment)

Summary: Enable async PlacesTransactions → Enable async PlacesTransactions in Nightly
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Priority: -- → P1
Whiteboard: [qf]
Points: 1 → ---
Flags: firefox-backlog+
Priority: P1 → P2
Whiteboard: [qf] → [photon-performance] [qf]

Comment 1

2 years ago
Mike, do you have information on what this can be expected to improve performance wise?  It's not clear to me what the perf impact of this can be...
Flags: needinfo?(mconley)
All the bookmarks UI is currently using the old synchronous transactions for every change.
Basically, adding/removing/editing/moving one or more bookmarks go through this.
All of those operations cause main-thread I/O.
The new async transactions are expected to solve that problem (once the dependencies here are fixed), moving I/O off the main thread through the new Bookmarks API.
See comment 2. :)
Flags: needinfo?(mconley)
Whiteboard: [photon-performance] [qf] → [photon-performance] [qf:meta]
Priority: P2 → P3
Whiteboard: [photon-performance] [qf:meta] → [reserve-photon-performance] [qf:meta]
Priority: P3 → P2
Priority: P2 → P3
Whiteboard: [reserve-photon-performance] [qf:meta] → [reserve-photon-performance] [p2] [qf:meta]
Priority: P3 → P1
Whiteboard: [reserve-photon-performance] [p2] [qf:meta] → [reserve-photon-performance] [p2] [qf:meta][fxsearch]
Whiteboard: [reserve-photon-performance] [p2] [qf:meta][fxsearch] → [qf:meta][fxsearch]
(Assignee)

Updated

2 years ago
Depends on: 1376531
No longer depends on: 1160211
(Assignee)

Updated

2 years ago
Depends on: 1376925
(Assignee)

Updated

2 years ago
Depends on: 1376929
(Assignee)

Updated

2 years ago
Depends on: 1377598
(Assignee)

Updated

2 years ago
Depends on: 1377599
(Assignee)

Updated

2 years ago
Depends on: 1377600
(Assignee)

Updated

2 years ago
Depends on: 1378132
(Assignee)

Updated

2 years ago
Depends on: 1378711
(Assignee)

Updated

2 years ago
Depends on: 1380570
Comment hidden (mozreview-request)
(Assignee)

Comment 5

2 years ago
Once the remaining deps are landed, I'll trigger a try build with this patch as well, and just confirm everything is still green. Then we'll land and see how it goes :-)
Assignee: nobody → standard8
Depends on: 1380599

Comment 6

2 years ago
mozreview-review
Comment on attachment 8886116 [details]
Bug 1071513 - Enable async PlacesTransactions for nightly builds.

https://reviewboard.mozilla.org/r/156918/#review162468

r=me once we have a green Try (may be worth retriggering all mochitest-browser tests at least once).

We must coordinate with QA at the next team meeting to create a test plan for letting this go to release in 57.
Attachment #8886116 - Flags: review?(mak77) → review+
(Assignee)

Comment 7

2 years ago
Try build with all the latest changes is here (based on autoland as that's where they all are): https://treeherder.mozilla.org/#/jobs?repo=try&revision=92d0675c90d26b0856c4cded8093db36e8c4b427
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Depends on: 1381027
(Assignee)

Comment 9

2 years ago
Looks like we need to resolve bug 1336806 or a variant of it before we can push this.

Comment 10

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a4690dfd7b3
Enable async PlacesTransactions for nightly builds. r=mak

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0a4690dfd7b3
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Updated

2 years ago
Depends on: 1383138

Updated

2 years ago
Depends on: 1386513

Updated

2 years ago
Depends on: 1391166

Updated

2 years ago
Depends on: 1391393
(Assignee)

Updated

2 years ago
Depends on: 1393021
(Assignee)

Updated

2 years ago
No longer depends on: 1393021

Updated

2 years ago
Depends on: 1397369

Updated

2 years ago
Depends on: 1397387
(Assignee)

Updated

2 years ago
No longer depends on: 1404909
(Assignee)

Updated

2 years ago
Blocks: 1405242
No longer depends on: 1405242

Updated

a year ago
Depends on: 1434261

Updated

a year ago
Depends on: 1440644
You need to log in before you can comment on or make changes to this bug.