Closed Bug 1071513 Opened 7 years ago Closed 4 years ago

Enable async PlacesTransactions in Nightly

Categories

(Firefox :: Bookmarks & History, defect, P1)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: mano, Assigned: standard8)

References

(Depends on 1 open bug, Blocks 3 open bugs)

Details

(Keywords: perf, Whiteboard: [qf:meta][fxsearch])

Attachments

(1 file)

Bug 1071513 - Enable async PlacesTransactions for nightly builds.
59 bytes, text/x-review-board-request
mak
: review+
Details
Depends on: 984904, 951651, 937560
Summary: Enable async PlacesTransactions → Enable async PlacesTransactions in Nightly
Depends on: 1095425
Depends on: 1158750
Depends on: 1158887
Depends on: 1160211
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Priority: -- → P1
Keywords: perf
Points: 1 → ---
Flags: firefox-backlog+
Priority: P1 → P2
Whiteboard: [qf] → [photon-performance] [qf]
Mike, do you have information on what this can be expected to improve performance wise?  It's not clear to me what the perf impact of this can be...
Flags: needinfo?(mconley)
All the bookmarks UI is currently using the old synchronous transactions for every change.
Basically, adding/removing/editing/moving one or more bookmarks go through this.
All of those operations cause main-thread I/O.
The new async transactions are expected to solve that problem (once the dependencies here are fixed), moving I/O off the main thread through the new Bookmarks API.
See comment 2. :)
Flags: needinfo?(mconley)
Whiteboard: [photon-performance] [qf] → [photon-performance] [qf:meta]
Priority: P2 → P3
Whiteboard: [photon-performance] [qf:meta] → [reserve-photon-performance] [qf:meta]
Priority: P3 → P2
Priority: P2 → P3
Whiteboard: [reserve-photon-performance] [qf:meta] → [reserve-photon-performance] [p2] [qf:meta]
Priority: P3 → P1
Whiteboard: [reserve-photon-performance] [p2] [qf:meta] → [reserve-photon-performance] [p2] [qf:meta][fxsearch]
Whiteboard: [reserve-photon-performance] [p2] [qf:meta][fxsearch] → [qf:meta][fxsearch]
Depends on: 1376531
No longer depends on: 1160211
Depends on: 1376925
Depends on: 1376929
Depends on: 1377598
Depends on: 1377599
Depends on: 1377600
Depends on: 1378132
Depends on: 1378711
Depends on: 1380570
Once the remaining deps are landed, I'll trigger a try build with this patch as well, and just confirm everything is still green. Then we'll land and see how it goes :-)
Assignee: nobody → standard8
Depends on: 1380599
Comment on attachment 8886116 [details]
Bug 1071513 - Enable async PlacesTransactions for nightly builds.

https://reviewboard.mozilla.org/r/156918/#review162468

r=me once we have a green Try (may be worth retriggering all mochitest-browser tests at least once).

We must coordinate with QA at the next team meeting to create a test plan for letting this go to release in 57.
Attachment #8886116 - Flags: review?(mak77) → review+
Try build with all the latest changes is here (based on autoland as that's where they all are): https://treeherder.mozilla.org/#/jobs?repo=try&revision=92d0675c90d26b0856c4cded8093db36e8c4b427
Status: NEW → ASSIGNED
Depends on: 1381027
Looks like we need to resolve bug 1336806 or a variant of it before we can push this.
Depends on: 1336806
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a4690dfd7b3
Enable async PlacesTransactions for nightly builds. r=mak
https://hg.mozilla.org/mozilla-central/rev/0a4690dfd7b3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Depends on: 1383138
Depends on: 1386513
Depends on: 1391166
Depends on: 1391393
Depends on: 1393021
No longer depends on: 1393021
Depends on: 1397369
Depends on: 1397387
No longer depends on: 1404909
Blocks: 1405242
No longer depends on: 1405242
Depends on: 1434261
Depends on: 1440644
You need to log in before you can comment on or make changes to this bug.