Closed
Bug 1071515
Opened 10 years ago
Closed 9 years ago
Test failure 'The Close button has not been found' in /testSecurity/testSafeBrowsingNotificationBar.js
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(firefox33 wontfix, firefox34 wontfix, firefox35 fixed, firefox36 fixed, firefox37 fixed, firefox38 fixed, firefox-esr31 fixed)
People
(Reporter: andrei, Assigned: teodruta)
References
(Depends on 1 open bug, )
Details
(Keywords: intermittent-failure, Whiteboard: [mozmill-test-failure])
Attachments
(4 files)
247.04 KB,
image/png
|
Details | |
1.62 KB,
patch
|
AndreeaMatei
:
review+
mihaelav
:
review+
|
Details | Diff | Splinter Review |
2.60 KB,
patch
|
AndreeaMatei
:
review+
mihaelav
:
review+
|
Details | Diff | Splinter Review |
1.61 KB,
patch
|
AndreeaMatei
:
review+
|
Details | Diff | Splinter Review |
Module: testNotificationBar Test: /testSecurity/testSafeBrowsingNotificationBar.js Failure: The Close button has not been found Branches: mozilla-beta Platforms: OSX 10.6 Locale: bh-BD Report: http://mozmill-release.blargon7.com/#/remote/report/2f982f72826307fed840a3b11ceefdbd Only 1 occurrence. Does not reproduce (tested same build on OSX 10.9).
Reporter | ||
Comment 1•10 years ago
|
||
Actually failed twice, with the same locale! http://mozmill-release.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2014-09-23&test=%2FtestSecurity%2FtestSafeBrowsingNotificationBar.js&func=testNotificationBar XP and OSX
Summary: Test failure 'The Close button has not been found' in /testSecurity/testSafeBrowsingNotificationBar.js → [bn-BD?] Test failure 'The Close button has not been found' in /testSecurity/testSafeBrowsingNotificationBar.js
Comment 2•10 years ago
|
||
This test is using the selectedIndex property. I believe it could be related to the other bug Daniel is currently working on.
Reporter | ||
Comment 3•10 years ago
|
||
3rd instance, same locale bn-BD: http://mozmill-release.blargon7.com/#/remote/report/bfd52839a01858de2f33d25f7651600e Again OSX 10.6 I wasn't able to reproduce on OSX 10.9, I'll check a 10.6 system.
Reporter | ||
Comment 4•10 years ago
|
||
Can't reproduce on OSX 10.6
Reporter | ||
Updated•10 years ago
|
status-firefox32:
--- → affected
Reporter | ||
Comment 6•10 years ago
|
||
Seems we have failures on different locales as well: http://mozmill-release.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2014-09-24&test=%2FtestSecurity%2FtestSafeBrowsingNotificationBar.js&func=testNotificationBar
Keywords: intermittent-failure
Priority: P4 → P2
Summary: [bn-BD?] Test failure 'The Close button has not been found' in /testSecurity/testSafeBrowsingNotificationBar.js → Test failure 'The Close button has not been found' in /testSecurity/testSafeBrowsingNotificationBar.js
Comment 7•10 years ago
|
||
We should definetely take care of this bug. 20 failures today only (check link in Comment 6), also we had crashes: http://mozmill-release.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2014-09-24&test=%2FtestSecurity%2FtestSafeBrowsingNotificationBar.js&func=testSafeBrowsingNotificationBar.js
Comment 8•10 years ago
|
||
Please check comment 2! I strongly believe this is related. Not exactly sure which bug# this is.
Comment 9•10 years ago
|
||
Failed for 35 times, all on the same time-span, non-reproducible. http://mozmill-release.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2014-10-01&to=&test=%2FtestSecurity%2FtestSafeBrowsingNotificationBar.js&func=testNotificationBar
Comment 10•10 years ago
|
||
14 times with today's beta.
Comment 11•10 years ago
|
||
I believe this is related to the resolution we use and because we have a smaller Firefox window in testruns (not maximized), the X button to close the notification is not fully visible. It can be reproduced that way.
Comment 12•10 years ago
|
||
Failed 34 times with latest beta (maybe more if there weren't that other failure this test has - controller.waitForPageLoad())
status-firefox32:
affected → ---
status-firefox34:
--- → affected
Comment 13•10 years ago
|
||
Andreea, do you have a screenshot to share with us?
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → teodor.druta
Status: NEW → ASSIGNED
Assignee | ||
Comment 14•10 years ago
|
||
The issue is related to the browser window size/screen resolution. For some locales the text fits in a larger space that is provided by the notification bar size, resulting in the close button not being fully visible, so the click event can not be triggered. Note: The bottom scrollbar scrolls the page content and will not make the button visible if scrolled to the right.
Comment 15•10 years ago
|
||
Interesting. Usually the text at the left side should wrap, and even cause a 3rd line of text to appear. Does that happen when you make the window even smaller? If that is the case and the stop button is still not fully visible there might be a problem in Firefox itself. We should reserve enough space for the close button to be visible. As what I see right now it could fit into the cut-off element l10n test.
Reporter | ||
Comment 16•10 years ago
|
||
Indeed that looks like a Firefox issue.
Teodor, please file a bug against the relevant component. (not sure which this is, a good bet is probably Toolkit :: Notifications and Alerts). It should block this bug. It might be a good idea to also link or re-attach attachment 8506027 [details] in the new bug.
status-firefox35:
--- → affected
status-firefox36:
--- → affected
Assignee | ||
Comment 17•10 years ago
|
||
For some locales there are only 2 words meaning "Reported Attack Site", so it can't wrap on three lines. Where there are 3 words, it indeed wraps on three lines, but on a smaller browser window the close button will be clipped fully or partial, and the click event will still not trigger.
Comment 18•10 years ago
|
||
Failed for 39 times since yesterday, let's get this skipped.
Priority: P2 → P1
Assignee | ||
Comment 19•9 years ago
|
||
Fixed this failure by maximizing the window at test start. Added a TODO comment for when the Bug 1084289 gets fixed.
Attachment #8559800 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8559800 -
Flags: review?(andreea.matei)
Assignee | ||
Updated•9 years ago
|
status-firefox37:
--- → affected
status-firefox38:
--- → affected
Assignee | ||
Comment 20•9 years ago
|
||
This is the patch for aurora, beta and release branches, including the maximize() and restore() methods in BaseWindow class
Attachment #8559804 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8559804 -
Flags: review?(andreea.matei)
Updated•9 years ago
|
Attachment #8559800 -
Flags: review?(mihaela.velimiroviciu) → review+
Updated•9 years ago
|
Attachment #8559804 -
Flags: review?(mihaela.velimiroviciu) → review+
Comment 21•9 years ago
|
||
Comment on attachment 8559800 [details] [diff] [review] fixsafebrowsingnotificationbar.patch Review of attachment 8559800 [details] [diff] [review]: ----------------------------------------------------------------- https://hg.mozilla.org/qa/mozmill-tests/rev/f9e4c51d8cec (default)
Attachment #8559800 -
Flags: review?(andreea.matei) → review+
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8559804 -
Flags: review?(andreea.matei) → review+
Comment 22•9 years ago
|
||
Comment on attachment 8559804 [details] [diff] [review] fixsafebrowsingnotificationbar_aurora_beta_release.patch Review of attachment 8559804 [details] [diff] [review]: ----------------------------------------------------------------- https://hg.mozilla.org/qa/mozmill-tests/rev/8f09e882a830 (aurora) https://hg.mozilla.org/qa/mozmill-tests/rev/a40798eb3a8a (beta) https://hg.mozilla.org/qa/mozmill-tests/rev/4393be527725 (release) ESR31 needs another patch?
Updated•9 years ago
|
Assignee | ||
Comment 23•9 years ago
|
||
(In reply to Andreea Matei [:AndreeaMatei] from comment #22) > ESR31 needs another patch? We can't backport this to esr31 beacause don't have the BaseWindow class on the mozilla-esr31 branch.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox-esr31:
--- → wontfix
Resolution: --- → FIXED
Comment 24•9 years ago
|
||
This test is failing on ESR31, so you cannot simply mark it as wontfix. If BaseWindow does not exist you will have to come up with an alternative implementation.
Assignee | ||
Comment 25•9 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #24) > This test is failing on ESR31, so you cannot simply mark it as wontfix. If > BaseWindow does not exist you will have to come up with an alternative > implementation. :(
Attachment #8561463 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8561463 -
Flags: review?(andreea.matei)
Updated•9 years ago
|
Attachment #8561463 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8561463 -
Flags: review?(andreea.matei)
Attachment #8561463 -
Flags: review+
Comment 26•9 years ago
|
||
https://hg.mozilla.org/qa/mozmill-tests/rev/fe8184129e86 (esr31)
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•