1071515 - Test failure 'The Close button has not been found' in /testSecurity/testSafeBrowsingNotificationBar.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Andrei Eftimie]

Module:    testNotificationBar
Test:      /testSecurity/testSafeBrowsingNotificationBar.js    
Failure:   The Close button has not been found
Branches:  mozilla-beta
Platforms: OSX 10.6
Locale:    bh-BD
Report:    http://mozmill-release.blargon7.com/#/remote/report/2f982f72826307fed840a3b11ceefdbd

Only 1 occurrence. Does not reproduce (tested same build on OSX 10.9).

Comment 1

[Andrei Eftimie]

Actually failed twice, with the same locale!
http://mozmill-release.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2014-09-23&test=%2FtestSecurity%2FtestSafeBrowsingNotificationBar.js&func=testNotificationBar

XP and OSX

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This test is using the selectedIndex property. I believe it could be related to the other bug Daniel is currently working on.

Comment 3

[Andrei Eftimie]

3rd instance, same locale bn-BD:
http://mozmill-release.blargon7.com/#/remote/report/bfd52839a01858de2f33d25f7651600e

Again OSX 10.6
I wasn't able to reproduce on OSX 10.9, I'll check a 10.6 system.

Comment 4

[Andrei Eftimie]

Can't reproduce on OSX 10.6

Comment 6

[Andrei Eftimie]

Seems we have failures on different locales as well:
http://mozmill-release.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2014-09-24&test=%2FtestSecurity%2FtestSafeBrowsingNotificationBar.js&func=testNotificationBar

Comment 7

[Daniel Gherasim]

We should definetely take care of this bug.
20 failures today only (check link in Comment 6), also we had crashes:

http://mozmill-release.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2014-09-24&test=%2FtestSecurity%2FtestSafeBrowsingNotificationBar.js&func=testSafeBrowsingNotificationBar.js

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please check comment 2! I strongly believe this is related. Not exactly sure which bug# this is.

Comment 9

[Cosmin Malutan, [:cosmin-malutan]]

Failed for 35 times, all on the same time-span, non-reproducible.
http://mozmill-release.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2014-10-01&to=&test=%2FtestSecurity%2FtestSafeBrowsingNotificationBar.js&func=testNotificationBar

Comment 10

[Andreea Matei [:AndreeaMatei]]

14 times with today's beta.

Comment 11

[Andreea Matei [:AndreeaMatei]]

I believe this is related to the resolution we use and because we have a smaller Firefox window in testruns (not maximized), the X button to close the notification is not fully visible. It can be reproduced that way.

Comment 12

[Andreea Matei [:AndreeaMatei]]

Failed 34 times with latest beta (maybe more if there weren't that other failure this test has - controller.waitForPageLoad())

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Andreea, do you have a screenshot to share with us?

Comment 14

[Teodor Druta]

Attachment: Screenshot

The issue is related to the browser window size/screen resolution. For some locales the text fits in a larger space that is provided by the notification bar size, resulting in the close button not being fully visible, so the click event can not be triggered.
Note: The bottom scrollbar scrolls the page content and will not make the button visible if scrolled to the right.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Interesting. Usually the text at the left side should wrap, and even cause a 3rd line of text to appear. Does that happen when you make the window even smaller? If that is the case and the stop button is still not fully visible there might be a problem in Firefox itself. We should reserve enough space for the close button to be visible. As what I see right now it could fit into the cut-off element l10n test.

Comment 16

[Andrei Eftimie]

Indeed that looks like a Firefox issue.

Teodor, please file a bug against the relevant component. (not sure which this is, a good bet is probably Toolkit :: Notifications and Alerts). It should block this bug. It might be a good idea to also link or re-attach attachment 8506027 [details] in the new bug.

Comment 17

[Teodor Druta]

For some locales there are only 2 words meaning "Reported Attack Site", so it can't wrap on three lines. Where there are 3 words, it indeed wraps on three lines, but on a smaller browser window the close button will be clipped fully or partial, and the click event will still not trigger.

Comment 18

[Cosmin Malutan, [:cosmin-malutan]]

Failed for 39 times since yesterday, let's get this skipped.

Comment 19

[Teodor Druta]

Attachment: fixsafebrowsingnotificationbar.patch

Fixed this failure by maximizing the window at test start. Added a TODO comment for when the Bug 1084289 gets fixed.

Comment 20

[Teodor Druta]

Attachment: fixsafebrowsingnotificationbar_aurora_beta_release.patch

This is the patch for aurora, beta and release branches, including the maximize() and restore() methods in BaseWindow class

Comment 21

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8559800 [details] [diff] [review]
fixsafebrowsingnotificationbar.patch

Review of attachment 8559800 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/qa/mozmill-tests/rev/f9e4c51d8cec (default)

Comment 22

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8559804 [details] [diff] [review]
fixsafebrowsingnotificationbar_aurora_beta_release.patch

Review of attachment 8559804 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/qa/mozmill-tests/rev/8f09e882a830 (aurora)
https://hg.mozilla.org/qa/mozmill-tests/rev/a40798eb3a8a (beta)
https://hg.mozilla.org/qa/mozmill-tests/rev/4393be527725 (release)

ESR31 needs another patch?

Comment 23

[Teodor Druta]

(In reply to Andreea Matei [:AndreeaMatei] from comment #22)
> ESR31 needs another patch?

We can't backport this to esr31 beacause don't have the BaseWindow class on the mozilla-esr31 branch.

Comment 24

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This test is failing on ESR31, so you cannot simply mark it as wontfix. If BaseWindow does not exist you will have to come up with an alternative implementation.

Comment 25

[Teodor Druta]

Attachment: fixsafeesr.patch

(In reply to Henrik Skupin (:whimboo) from comment #24)
> This test is failing on ESR31, so you cannot simply mark it as wontfix. If
> BaseWindow does not exist you will have to come up with an alternative
> implementation.

:(

Comment 26

[Andreea Matei [:AndreeaMatei]]

https://hg.mozilla.org/qa/mozmill-tests/rev/fe8184129e86 (esr31)