1071525 - [Loop] Closing Loop app revoke all the shared URL's

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[mbarone]

Device: Flame, v.2.0 (KK v180)
Gecko-d87b9af.Gaia-0658006
Loop Id: c56785f

STR
1. Create some shared URL's (ex. I've 4 shared URL's in the call log)
2. Revoke the first 3 shared URL in the call log
3. Click on Home button in order to kill the Loop app
4. Open Loop app again

ACTUAL RESULT
The Shared URL tab shows all the URL as Disabled/Revoked, also the last one that I didn't disable

EXPECTED RESULT
The shared URL tab should show only the first 3 URL as Disabled/Revoked

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

(In reply to mbarone from comment #0)
> Device: Flame, v.2.0 (KK v180)
> Gecko-d87b9af.Gaia-0658006
> Loop Id: c56785f
> 
> STR
> 1. Create some shared URL's (ex. I've 4 shared URL's in the call log)
> 2. Revoke the first 3 shared URL in the call log
> 3. Click on Home button in order to kill the Loop app
> 4. Open Loop app again
> 
> ACTUAL RESULT
> The Shared URL tab shows all the URL as Disabled/Revoked, also the last one
> that I didn't disable
> 

Is the last URL still working? Can you try pasting it in the browser to see if it is really revoked or not. If it is not revoked this might be just something wrong with the call log.

Comment 2

[Maria Angeles Oteo (:oteo)]

Hi Fer,
that URL is working although in the "Shared links" tab, that URL is shown like "revoked", so it seems to be related with the Call Log.

Comment 3

[Cristian Rodriguez (:crdlc)]

Borja, are you working on it? thanks

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

thanks Jose

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8501645 [details]
Github pull request

I don't feel comfortable reviewing this part of the app. Forwarding this review to Fernando. Sorry Cristian!

Comment 6

[Cristian Rodriguez (:crdlc)]

OK, no problem 

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #5)
> Comment on attachment 8501645 [details]
> Github pull request
> 
> I don't feel comfortable reviewing this part of the app. Forwarding this
> review to Fernando. Sorry Cristian!

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8501645 [details]
Github pull request

Thanks Cristian! LGTM. I only added a few comments to the PR. r=me with these comments addressed.

Comment 8

[Cristian Rodriguez (:crdlc)]

Comments addressed

Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/1156718cfe51d13ef475bb1462a53582b66e335c

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

Follow up https://github.com/mozilla-b2g/firefoxos-loop-client/commit/5b261c5b21c03709c51a5963961d6ea5fe92940e

Comment 10

[Javier de Prado]

Verified on:
Flame: user.v2.0.184based.B-57.Gecko-dde9d61.Gaia-7b8df99
FireE: firee-kk-v2.0-SW2E5-4
Loop 1.1, version: aba155c