Closed Bug 1071527 Opened 10 years ago Closed 10 years ago

"dom.performance.enabled" set to "false" shows non-zero values for attributes

Categories

(Core :: DOM: Core & HTML, defect)

31 Branch
x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: gk, Assigned: valentin)

References

Details

Attachments

(1 file)

Despite "dom.performance.enabled" set to "false" there are Navigation Timing API related values which are non-zero:

> performance.timing
< PerformanceTiming { navigationStart: 0, unloadEventStart: 0, 
unloadEventEnd: 0, redirectStart: 1411030797789, redirectEnd: 1411030797789, 
fetchStart: 1411030797789, domainLookupStart: 1411030797789, 
domainLookupEnd: 1411030797789, connectStart: 1411030797789, 
connectEnd: 1411030797789 }

This is due https://hg.mozilla.org/mozilla-central/rev/a5679c8bc3fe where |return 0;| got replaced by |return mZeroTime;|. Although this change does not disclose how long the different parts of loading a website took it does not match users' expectations to leak related information at all if the preference is disabled.

Returning "0" seems to be the preferable way here.
Summary: "dom.performance.enabled" set to "false" show non-zero values for attributes → "dom.performance.enabled" set to "false" shows non-zero values for attributes
Flags: needinfo?(valentin.gosu)
Assignee: nobody → valentin.gosu
Status: NEW → ASSIGNED
Thanks for reporting this Georg.
Flags: needinfo?(valentin.gosu)
Comment on attachment 8493983 [details] [diff] [review]
"dom.performance.enabled" set to "false" shows non-zero values for attributes

r=me
Attachment #8493983 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/007c2dea78c1
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.