Fix more bad implicit constructors in DOM

RESOLVED FIXED in mozilla35

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

unspecified
mozilla35
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8493712 [details] [diff] [review]
Fix more bad implicit constructors in DOM
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan.akhgari
Blocks: 1009631
(Assignee)

Updated

3 years ago
Attachment #8493712 - Flags: review?(amarchesini)
Comment on attachment 8493712 [details] [diff] [review]
Fix more bad implicit constructors in DOM

Review of attachment 8493712 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLSampler.h
@@ +30,1 @@
>  

aContext

::: dom/canvas/WebGLStrongTypes.h
@@ +114,5 @@
>              MOZ_ASSERT(mValue != LOCAL_GL_NONE);   \
>              return mValue;                         \
>          }                                          \
>                                                     \
> +        MOZ_IMPLICIT NAME(GLenum val)              \

aVal

::: dom/canvas/WebGLSync.h
@@ +23,5 @@
>      friend class WebGL2Context;
>  
>  public:
>  
> +    explicit WebGLSync(WebGLContext* context);

aContext

::: dom/canvas/WebGLTransformFeedback.h
@@ +25,5 @@
>      friend class WebGLContext;
>  
>  public:
>  
> +    explicit WebGLTransformFeedback(WebGLContext* context);

aContext
Attachment #8493712 - Flags: review?(amarchesini) → review+
https://hg.mozilla.org/mozilla-central/rev/a7c3eb6b1639
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.