Closed
Bug 1071571
Opened 10 years ago
Closed 10 years ago
Fix more bad implicit constructors in DOM
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
4.69 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8493712 -
Flags: review?(amarchesini)
Comment 2•10 years ago
|
||
Comment on attachment 8493712 [details] [diff] [review] Fix more bad implicit constructors in DOM Review of attachment 8493712 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/canvas/WebGLSampler.h @@ +30,1 @@ > aContext ::: dom/canvas/WebGLStrongTypes.h @@ +114,5 @@ > MOZ_ASSERT(mValue != LOCAL_GL_NONE); \ > return mValue; \ > } \ > \ > + MOZ_IMPLICIT NAME(GLenum val) \ aVal ::: dom/canvas/WebGLSync.h @@ +23,5 @@ > friend class WebGL2Context; > > public: > > + explicit WebGLSync(WebGLContext* context); aContext ::: dom/canvas/WebGLTransformFeedback.h @@ +25,5 @@ > friend class WebGLContext; > > public: > > + explicit WebGLTransformFeedback(WebGLContext* context); aContext
Attachment #8493712 -
Flags: review?(amarchesini) → review+
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a7c3eb6b1639
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•10 years ago
|
Flags: qe-verify-
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•