Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sheppy, Assigned: shobson)

Tracking

Details

(Whiteboard: [specification][type:change])

(Reporter)

Description

5 years ago
What feature should be changed? Please provide the URL of the feature if possible.
==================================================================================
We need to add the following CSS to the custom CSS:

/* help ensure the vertical alignment of elements in a row of download boxes */
.download-desc { min-height: 172px; }


What problems would this solve?
===============================
This corrects a visual problem on the /docs/Firefox page.

Who would use this?
===================
All

What would users see?
=====================
Nicer display of elements.

What would users do? What would happen as a result?
===================================================
Revel in the wonderfulness of horizontally aligned content.

Is there anything else we should know?
======================================
Ideally this should be near the other classes prefixed "download-".
:shobson, :davidwalsh, :openjck - in addition to adding this, how do we want to do this in the future? Do we want devs to add this, or ask :sheppy and writers to send pull requests?
Flags: needinfo?(shobson)
Flags: needinfo?(jkarahalis)
Flags: needinfo?(dwalsh)
I'm fine with implementing it for them, though I'm thinking there may be a better way in this case.

Sheppy:  What URL or content does this apply to?
Flags: needinfo?(dwalsh) → needinfo?(eshepherd)
(Reporter)

Comment 3

5 years ago
This is used on https://developer.mozilla.org/en-US/Firefox to tidy the appearance of the four channel download boxes. This was the best advice I was able to get when I was working on this issue yesterday.
Flags: needinfo?(eshepherd)
(In reply to Luke Crouch [:groovecoder] from comment #1)
> :shobson, :davidwalsh, :openjck - in addition to adding this, how do we want
> to do this in the future? Do we want devs to add this, or ask :sheppy and
> writers to send pull requests?

Either way. Whatever works for the writers, really.

If we do decide to manage these changes through bugs, I would love for us to promise 24-hour turnarounds.
Flags: needinfo?(jkarahalis)
Or more accurately, 24-hour replies. Some changes will benefit from further discussion, and I wouldn't want us to rush implementation in those cases.
(Reporter)

Comment 6

5 years ago
I would prefer to use bugs rather than PRs because, honestly, keeping a stable build environment intact for the purpose of tweaking CSS is a lot to ask. :)
I think it's fair to send the PR with CSS changes without a build environment running.
(Reporter)

Comment 8

5 years ago
(In reply to Luke Crouch [:groovecoder] from comment #7)
> I think it's fair to send the PR with CSS changes without a build
> environment running.

Someone will have to explain how to do that, because I don't know.

In the meantime, can someone please deploy this fix? :)
(Assignee)

Updated

5 years ago
Assignee: nobody → shobson
Flags: needinfo?(shobson)
(Assignee)

Comment 9

5 years ago
Would it be okay if I took a different approach here? I'd like to do something that will work on mobile as well.
Flags: needinfo?(eshepherd)
(Assignee)

Comment 10

5 years ago
The goal is to make the buttons line up at the bottom, correct?
(Reporter)

Comment 11

5 years ago
Okay, this has taken over a week now. I'm about ready to throw the waffle flag so we can start using CustomCSS again. There's no way this should have taken this long, given that we were told that you guys would respond quickly to requests to push CSS tweaks. :)

Yes, the goal is to line the buttons up at the bottom, *and* the headings at the top.
Flags: needinfo?(eshepherd)
:shobson - to whom was your question directed in comment 10?
Flags: needinfo?(shobson)
(Assignee)

Comment 13

5 years ago
:groovecoder It was directed at Sheppy and he answered it.
Flags: needinfo?(shobson)
(Assignee)

Comment 14

5 years ago
Pull request is under review.

Comment 15

5 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/4f26bf6b8977ab82a1b71344ea4caa89c129024c
Fix Bug 1071591 - Download description alignments

To keep headings aligned at the top I removed vertical-align:centre and to keep buttons aligned at the bottom I absolutely position them at the bottom in a space created by adding padding to the bottom of the description.

Also added a fix to keep the "headings" on a separate line on mobile since they look weird on the same line as the image.

https://github.com/mozilla/kuma/commit/5cf8101742c077e8be3da4416e4fcbeb51529dac
Merge pull request #2792 from stephaniehobson/BUG-1071591-download-desc-align

Fix Bug 1071591 - Download description alignments

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.