1071615 - Fail codegen when "A implements B" appears in a webidl file different from the webidl file A appears in

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Our build system doesn't support this for dep builds, because adding "A implements B" to B.webidl gives no indication that A.webidl needs to be reprocessed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make codegen fail when "A implements B" appears on a Web IDL file different from the file A is defined in

Tells you how much we have in the way of tests for feFlood....

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8493783 [details] [diff] [review]
Make codegen fail when "A implements B" appears on a Web IDL file different from the file A is defined in

Review of attachment 8493783 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/SVGFEFloodElement.webidl
@@ +12,5 @@
>  
>  interface SVGFEFloodElement : SVGElement {
>  };
>  
> +SVGFEFloodElement implements SVGFilterPrimitiveStandardAttributes;

lol

Comment 3

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16411120d562

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/16411120d562