Closed Bug 1071615 Opened 5 years ago Closed 5 years ago

Fail codegen when "A implements B" appears in a webidl file different from the webidl file A appears in

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Our build system doesn't support this for dep builds, because adding "A implements B" to B.webidl gives no indication that A.webidl needs to be reprocessed.
Tells you how much we have in the way of tests for feFlood....
Attachment #8493783 - Flags: review?(khuey)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8493783 [details] [diff] [review]
Make codegen fail when "A implements B" appears on a Web IDL file different from the file A is defined in

Review of attachment 8493783 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/SVGFEFloodElement.webidl
@@ +12,5 @@
>  
>  interface SVGFEFloodElement : SVGElement {
>  };
>  
> +SVGFEFloodElement implements SVGFilterPrimitiveStandardAttributes;

lol
Attachment #8493783 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/16411120d562
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.