1071746 - Add unit tests to validate json files in tools repo to avoid bustage

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Pete Moore [:pmoore][:pete]]

Add unit tests to avoid invalid json files getting checked in, e.g. bug 1071518.

Comment 1

[Pete Moore [:pmoore][:pete]]

Attachment: bug1071746_tools_v1.patch

I'll scan other repos tomorrow to see if we want similar ones for other repos too, and will add them to this bug.

Comment 2

[Ed Morley [:emorley]]

This is great, thank you for following up on root causes! :-)

Comment 3

[Pete Moore [:pmoore][:pete]]

Attachment: bug1071746_tools_v2.patch

Based on your initial feedback on IRC, an updated patch...

Comment 4

[Massimo Gervasini [:massimo]]

Comment on attachment 8495834 [details] [diff] [review]
bug1071746_tools_v2.patch

Review of attachment 8495834 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Pete, works for me. Could you remove "#!/usr/bin/env python" before committing it? (the other tests do not have it)

Comment 5

[Pete Moore [:pmoore][:pete]]

The three new tests passed:

http://10.134.48.37:8080/job/tools_tests/897/testReport/mozilla_buildtools.test.test_json_validity/JsonValidityTest/