Closed Bug 1071858 Opened 5 years ago Closed 5 years ago

[AccessFu] childCount is misleading when children have an aria-hidden="true" attribute.

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: yzen, Assigned: yzen)

References

Details

Attachments

(1 file, 1 obsolete file)

Right now childCount returns a plain length of accessible children. However, aria-hidden is not taken into account.

It affects the traversal through elements that depend on isSingleLineage or isFlatSubtree checks.
Blocks: 1069195
Attached patch 1071858 patch v1 (obsolete) — Splinter Review
Attachment #8494518 - Flags: review?(eitan)
Blocks: 1072305
Attached patch 1071858 patch v2Splinter Review
Attachment #8494518 - Attachment is obsolete: true
Attachment #8494518 - Flags: review?(eitan)
Attachment #8494627 - Flags: review?(eitan)
Comment on attachment 8494627 [details] [diff] [review]
1071858 patch v2

Review of attachment 8494627 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!
Attachment #8494627 - Flags: review?(eitan) → review+
https://hg.mozilla.org/mozilla-central/rev/caf6c61b1ea0
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.