1071934 - [shadow-dom] <video> in shadow-dom crashes app

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Wilson Page [:wilsonpage]]

Injecting a <video> element into the shadowRoot instantly crashes FxOS apps. This doesn't reproduce on desktop Firefox.

Comment 1

[Wilson Page [:wilsonpage]]

STEPS:

1. Flash device with this branch [1]
2. Launch Camera app
3. Observe app crashes

[1] https://github.com/wilsonpage/gaia/tree/1071934-test-case

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

crash-stat? Or do we not get those on FFOS?

Comment 3

[William Chen [:wchen]]

Attachment: Used GetComposedDoc() in nsVideoFrame

Looks like this is yet another case of GetCurrentDoc() vs GetComposedDoc()

Comment 4

[Wilson Page [:wilsonpage]]

(In reply to William Chen [:wchen] from comment #3)
> Created attachment 8494188 [details] [diff] [review]
> Used GetComposedDoc() in nsVideoFrame
> 
> Looks like this is yet another case of GetCurrentDoc() vs GetComposedDoc()

Do we have suitable reviewer for this patch?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8494188 [details] [diff] [review]
Used GetComposedDoc() in nsVideoFrame

How did I miss this.

Comment 6

[William Chen [:wchen]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2489b63b2493

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2489b63b2493