Status

defect
P3
normal
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: mcote, Assigned: asilva)

Tracking

(Blocks 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

48 bytes, text/x-github-pull-request
camd
: review+
Details | Review
(Reporter)

Description

5 years ago
Right now we set admin mode by editing the database directly.  We should have an admin view that allows existing admins to designate new admins, and maybe opt in or out of emails (bug 832415).

A command-line utility would be useful as well, so we can designate the first admin.
(Assignee)

Comment 1

3 years ago
Hello Mark,
Are you need this feature yet? I'm interested to develop it.
We can put a button on "all_pulse_users" list (when logged user is admin), or create a simple view to set user as admin.
(Assignee)

Comment 2

3 years ago
(In reply to Allan [:ex-dev] from comment #1)
> Hello Mark,
> Are you need this feature yet? I'm interested to develop it.
> We can put a button on "all_pulse_users" list (when logged user is admin),
> or create a simple view to set user as admin.

Just adding "need more info" flag to better track.
Flags: needinfo?(mcote)
(Reporter)

Comment 3

3 years ago
Yup still needed! I'm assigning you now. :)
Assignee: nobody → allan.tavares
Status: NEW → ASSIGNED
Flags: needinfo?(mcote)
(Assignee)

Comment 4

3 years ago
Hi Mark, I have not forgotten this bug. I had no time in last months due to a lot of my regular job.
(Assignee)

Comment 5

3 years ago
Posted file Link to PR on github (obsolete) —
Flags: needinfo?(mcote)
(Assignee)

Comment 6

3 years ago
Hi Mark, finally I came back to this bug.
A new PR (#19) is available.

An observation is: due to I am not a good English writer, some comments or messages can be wrong.

Thanks!
(Reporter)

Comment 7

2 years ago
Comment on attachment 8796879 [details] [review]
Link to PR on github

Changing this to a proper review request.
Flags: needinfo?(mcote)
Attachment #8796879 - Flags: review?(mcote)
(Reporter)

Comment 8

2 years ago
Comment on attachment 8796879 [details] [review]
Link to PR on github

I left some comments on the PR.  As I mentioned there, feel free to submit some fixes, or if you don't have time I can fix it up myself.  Thanks!
Attachment #8796879 - Flags: review?(mcote)
(Assignee)

Comment 9

2 years ago
(In reply to Mark Côté [:mcote] from comment #8)
> Comment on attachment 8796879 [details] [review]
> Link to PR on github
> 
> I left some comments on the PR.  As I mentioned there, feel free to submit
> some fixes, or if you don't have time I can fix it up myself.  Thanks!

Hi Mark!
I can submit fixes after Black Friday, I'm currently involved in some critical projects.
(Reporter)

Comment 10

2 years ago
Great!  No rush; just wanted to see if you're still around. :)
(Assignee)

Comment 11

2 years ago
Posted file PR Code Review
Attachment #8796879 - Attachment is obsolete: true
Attachment #8816972 - Flags: review?(mcote)
(Reporter)

Comment 12

2 years ago
Comment on attachment 8816972 [details] [review]
PR Code Review

So sorry I've neglected this (again).  I'm going to have camd take a look at this, since he's been doing some PulseGuardian work.  He should be able to get to it very soon.  Thanks again for the patch!
Attachment #8816972 - Flags: review?(mcote) → review?(cdawson)
Comment on attachment 8816972 [details] [review]
PR Code Review

Merged in a separate PR because I needed to rebase and add a small cleanup commit.  Thanks again for the PR!  Great feature!
Attachment #8816972 - Flags: review?(cdawson) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Blocks: 1347093
You need to log in before you can comment on or make changes to this bug.