1071938 - [PulseGuardian] Admin UI

Status: RESOLVED FIXED

(Webtools :: Pulse, defect, P3)

Description

[Mark Côté [:mcote]]

Right now we set admin mode by editing the database directly.  We should have an admin view that allows existing admins to designate new admins, and maybe opt in or out of emails (bug 832415).

A command-line utility would be useful as well, so we can designate the first admin.

Comment 1

[Allan [:asilva]]

Hello Mark,
Are you need this feature yet? I'm interested to develop it.
We can put a button on "all_pulse_users" list (when logged user is admin), or create a simple view to set user as admin.

Comment 2

[Allan [:asilva]]

(In reply to Allan [:ex-dev] from comment #1)
> Hello Mark,
> Are you need this feature yet? I'm interested to develop it.
> We can put a button on "all_pulse_users" list (when logged user is admin),
> or create a simple view to set user as admin.

Just adding "need more info" flag to better track.

Comment 3

[Mark Côté [:mcote]]

Yup still needed! I'm assigning you now. :)

Comment 4

[Allan [:asilva]]

Hi Mark, I have not forgotten this bug. I had no time in last months due to a lot of my regular job.

Comment 5

[Allan [:asilva]]

Attachment: Link to PR on github

Comment 6

[Allan [:asilva]]

Hi Mark, finally I came back to this bug.
A new PR (#19) is available.

An observation is: due to I am not a good English writer, some comments or messages can be wrong.

Thanks!

Comment 7

[Mark Côté [:mcote]]

Comment on attachment 8796879 [details] [review]
Link to PR on github

Changing this to a proper review request.

Comment 8

[Mark Côté [:mcote]]

Comment on attachment 8796879 [details] [review]
Link to PR on github

I left some comments on the PR.  As I mentioned there, feel free to submit some fixes, or if you don't have time I can fix it up myself.  Thanks!

Comment 9

[Allan [:asilva]]

(In reply to Mark Côté [:mcote] from comment #8)
> Comment on attachment 8796879 [details] [review]
> Link to PR on github
> 
> I left some comments on the PR.  As I mentioned there, feel free to submit
> some fixes, or if you don't have time I can fix it up myself.  Thanks!

Hi Mark!
I can submit fixes after Black Friday, I'm currently involved in some critical projects.

Comment 10

[Mark Côté [:mcote]]

Great!  No rush; just wanted to see if you're still around. :)

Comment 11

[Allan [:asilva]]

Attachment: PR Code Review

Comment 12

[Mark Côté [:mcote]]

Comment on attachment 8816972 [details] [review]
PR Code Review

So sorry I've neglected this (again).  I'm going to have camd take a look at this, since he's been doing some PulseGuardian work.  He should be able to get to it very soon.  Thanks again for the patch!

Comment 13

[Cameron Dawson [:camd]]

Comment on attachment 8816972 [details] [review]
PR Code Review

Merged in a separate PR because I needed to rebase and add a small cleanup commit.  Thanks again for the PR!  Great feature!