1071964 - openAndLoadSubDialog compares the injectedStylesheets against the owner document's stylesheets instead of the subdialog's stylesheets

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

If a stylesheet is added to the injectedStylesheet array but is not present in the preferences.xul file, the openAndLoadSubDialog() helper function will fail when making sure that all injected stylesheets are found.

This is because the function is currently looking at content.document.styleSheets, but it should instead be looking at content.gSubDialog._frame.contentDocument.styleSheets.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8494081 [details] [diff] [review]
Patch

Review of attachment 8494081 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/preferences/in-content/tests/head.js
@@ +54,5 @@
>      is_element_visible(content.gSubDialog._overlay, "Overlay is visible");
>  
>      // Check that stylesheets were injected
>      let expectedStyleSheetURLs = content.gSubDialog._injectedStyleSheets.slice(0);
> +    for (let styleSheet of content.gSubDialog._frame.contentDocument.styleSheets) {

Since the frame is already loaded in this case (we're in the load listener) this should be fine. Thanks

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/a3f673c67d31

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a3f673c67d31