1071987 - Win64 test failure in webgl-conformance/_wrappers/test_conformance__reading__read-pixels-test.html

Status: RESOLVED WORKSFORME

(Core :: Graphics: CanvasWebGL, defect)

Description

[(Away)]

Win64 debug only, regressed on m-c sometime between August 28 and September 22: https://tbpl.mozilla.org/php/getParsedLog.php?id=48651229&tree=Date

1096 INFO TEST-UNEXPECTED-FAIL | /tests/dom/canvas/test/webgl-conformance/_wrappers/test_conformance__reading__read-pixels-test.html | Should pass: conformance/reading/read-pixels-test.html - expected PASS

Jeff, I see you on blame for this file, but I'm not sure if you were just refactoring the tests. Could you recommend someone to investigate?

Comment 1

[Kelsey Gilbert [:jgilbert]]

(In reply to David Major [:dmajor] from comment #0)
> Win64 debug only, regressed on m-c sometime between August 28 and September
> 22: https://tbpl.mozilla.org/php/getParsedLog.php?id=48651229&tree=Date
> 
> 1096 INFO TEST-UNEXPECTED-FAIL |
> /tests/dom/canvas/test/webgl-conformance/_wrappers/
> test_conformance__reading__read-pixels-test.html | Should pass:
> conformance/reading/read-pixels-test.html - expected PASS
> 
> Jeff, I see you on blame for this file, but I'm not sure if you were just
> refactoring the tests. Could you recommend someone to investigate?

Can you reproduce this locally?
I just refactored the tests, but I'm also the best person to investigate them, if it is high priority enough.

Comment 2

[(Away)]

We're hoping to enable win64 tests on trunk soon. Yes, I can reproduce this. Here's a snippet from the test page:

check reading with lots of drawing
PASS read-pixels-test continueTestPart2: 1411516875820
PASS read-pixels-test before setupTexturedQuad: 1411516875820
PASS read-pixels-test after setupTexturedQuad: 1411516875838
PASS read-pixels-test before first loop: 1411516875839
PASS read-pixels-test first loop, ii = 0, before fillTexture: 1411516875840
PASS read-pixels-test first loop, ii = 0, after fillTexture: 1411516875841
PASS read-pixels-test first loop, ii = 1, before fillTexture: 1411516875841
PASS read-pixels-test first loop, ii = 1, after fillTexture: 1411516875842
PASS read-pixels-test first loop, ii = 2, before fillTexture: 1411516875842
PASS read-pixels-test first loop, ii = 2, after fillTexture: 1411516875843
PASS read-pixels-test second loop, ii = 0: 1411516875843
PASS read-pixels-test second loop, before readpixels: 1411516875851
PASS read-pixels-test second loop, after readpixels: 1411516875989
PASS read-pixels-test second loop end: 1411516875993
PASS read-pixels-test second loop, ii = 1: 1411516875994
PASS read-pixels-test second loop, before readpixels: 1411516876002
PASS read-pixels-test second loop, after readpixels: 1411516876178
PASS read-pixels-test second loop end: 1411516876180
PASS read-pixels-test second loop, ii = 2: 1411516876181
PASS read-pixels-test second loop, before readpixels: 1411516876185
PASS read-pixels-test second loop, after readpixels: 1411516876358
PASS read-pixels-test second loop end: 1411516876369
PASS read-pixels-test third loop, ii = 0: 1411516876370
> FAIL actual should be 255,0,0,255. Was 0,0,255,255.
PASS read-pixels-test third loop end: 1411516876374
PASS read-pixels-test third loop, ii = 1: 1411516876375
PASS actual is expected
PASS read-pixels-test third loop end: 1411516876376
PASS read-pixels-test third loop, ii = 2: 1411516876377
PASS actual is expected
PASS read-pixels-test third loop end: 1411516876378
PASS getError was expected value: NO_ERROR : there should be no GL errors

And from my terminal:

Initializing context 000000001E516C00 surface 000000001E50BB70 on display 000000000085ECD0
OpenGL version detected: 200
OpenGL vendor: Google Inc.
OpenGL renderer: ANGLE (NVIDIA Quadro 600 Direct3D9Ex vs_3_0 ps_3_0)
++DOCSHELL 000000001E448800 == 8 [pid = 6224] [id = 8]
++DOMWINDOW == 20 (000000001E7ADC00) [pid = 6224] [serial = 20] [outer = 0000000000000000]
[6224] WARNING: NS_ENSURE_TRUE(nsContentUtils::GetCurrentJSContext()) failed: file s:/win64/docshell/base/nsDocShell.cpp, line 9009
[6224] WARNING: Subdocument container has no frame: file s:/win64/layout/base/nsDocumentViewer.cpp, line 2515
++DOMWINDOW == 21 (000000001E7AE800) [pid = 6224] [serial = 21] [outer = 000000001E7ADC00]
JavaScript error: file:///s:/win64/obj/win64chk/dist/bin/components/nsHandlerService.js, line 891: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]
JavaScript error: file:///s:/win64/obj/win64chk/dist/bin/components/nsHandlerService.js, line 891: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]
JavaScript error: file:///s:/win64/obj/win64chk/dist/bin/components/nsHandlerService.js, line 891: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]
Initializing context 000000000086E160 surface 000000001E520680 on display 000000000085ECD0
OpenGL version detected: 200
OpenGL vendor: Google Inc.
OpenGL renderer: ANGLE (NVIDIA Quadro 600 Direct3D9Ex vs_3_0 ps_3_0)
JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-conformance/conformance/reading/read-pixels-test.html, line 162: Error: WebGL: readPixels: Invalid format/type pair
JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-conformance/conformance/reading/read-pixels-test.html, line 162: Error: WebGL: readPixels: Mismatched type/pixels types
JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-conformance/conformance/reading/read-pixels-test.html, line 162: Error: WebGL: readPixels: Invalid format/type pair
JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-conformance/conformance/reading/read-pixels-test.html, line 162: Error: WebGL: readPixels: Invalid format/type pair
JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-conformance/conformance/reading/read-pixels-test.html, line 162: Error: WebGL: readPixels: Invalid format/type pair
JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-conformance/conformance/reading/read-pixels-test.html, line 162: Error: WebGL: readPixels: Bad format
JavaScript warning: http://mochi.test:8888/tests/dom/canvas/test/webgl-conformance/conformance/reading/read-pixels-test.html, line 162: Error: WebGL: readPixels: Bad format
FAIL: actual should be 255,0,0,255. Was 0,0,255,255.
STACK TRACE:
testFailed@http://mochi.test:8888/tests/dom/canvas/test/webgl-conformance/resources/js-test-pre.js:91:18
continueTestPart2@http://mochi.test:8888/tests/dom/canvas/test/webgl-conformance/conformance/reading/read-pixels-test.html:227:5
continueTestPart1@http://mochi.test:8888/tests/dom/canvas/test/webgl-conformance/conformance/reading/read-pixels-test.html:179:5
@http://mochi.test:8888/tests/dom/canvas/test/webgl-conformance/conformance/reading/read-pixels-test.html:48:3

Is there any other output that would help? Or if you could distill the failing line into a super simple page then I could try stepping through if you want.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Ok, how can I make a 64-bit build to test this?

Comment 4

[(Away)]

I used "start-shell-msvc2010-x64.bat" and this mozconfig that I cargo-culted from the build machines:

ac_add_options --target=x86_64-pc-mingw32
ac_add_options --host=x86_64-pc-mingw32
ac_add_options --enable-debug
ac_add_options --enable-dmd
ac_add_options --enable-profiling

Comment 5

[(Away)]

The failure has gone away in recent builds: https://treeherder.mozilla.org/ui/#/jobs?repo=date&revision=335bc10c5ecb

Are you aware of any changes that might have fixed this? I worry it may have just gone into hiding and could come back up again.

Comment 6

[(Away)]

This test has been running for a while without any problems. I guess I'm not particularly interested in solving the mystery anymore.