1071996 - Use js_free to free memory allocated with JS_malloc in testXDR.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Guilherme Gonçalves [:ggp]]

Attachment: Use js_free to free memory allocated by JS_malloc in testXDR.cpp

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8494106 [details] [diff] [review]
Use js_free to free memory allocated by JS_malloc in testXDR.cpp

Review of attachment 8494106 [details] [diff] [review]:
-----------------------------------------------------------------

I'll batch this up for my next mass-push.  Thanks!

::: js/src/jsapi-tests/testXDR.cpp
@@ +31,5 @@
>             .setFileAndLine(filename, lineno)
>             .setVersion(version);
>      JS::RootedScript script(cx);
>      JS::Compile(cx, obj, options, chars, nchars, &script);
> +    js_free(chars);

JS_free, please, for consistency with JS_malloc.

Comment 3

[Nicholas Nethercote [inactive]]

> I'll batch this up for my next mass-push.  Thanks!

Or Guilherme could upload the final patch, do a try push (assuming he has access; if not, he should probably request it at this point) and then set the "checkin-needed" flag, and then someone like RyanVM will do it.

Comment 4

[Guilherme Gonçalves [:ggp]]

I'll do it. I'm just waiting for reviews on two other similar patches (bug 1071993 and bug 1071998, in case anyone wants to steal them), then I'll do a try run with all of them applied.

Comment 5

[Guilherme Gonçalves [:ggp]]

Attachment: Use js_free to free memory allocated by JS_malloc in testXDR.cpp

Using JS_free, carrying over :Waldo's r+.

Comment 6

[Guilherme Gonçalves [:ggp]]

Attachment: Use JS_free to free memory allocated by JS_malloc in testXDR.cpp

...and updating the commit message so it refers to JS_free as well. Apologies for the spam.

Comment 7

[Guilherme Gonçalves [:ggp]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=b14fe43da44f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07e5a8d5b119

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/07e5a8d5b119