Closed
Bug 1072036
Opened 10 years ago
Closed 10 years ago
UI Tour: Add ability to highlight new privacy button
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
People
(Reporter: Dolske, Assigned: Dolske)
References
Details
Attachments
(1 file, 1 obsolete file)
836 bytes,
patch
|
Dolske
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
If the user adds the new bug 1069300 button (using the new UITour feature from bug 1071238), it seems likely we'll want to then immediately hilight it. Trivial patch, so let's go ahead and do that.
Assignee | ||
Updated•10 years ago
|
Iteration: --- → 35.2
Points: --- → 2
Flags: firefox-backlog+
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8494155 [details] [diff] [review] Patch v.1 Review of attachment 8494155 [details] [diff] [review]: ----------------------------------------------------------------- Might as well get review, but I don't intend to land this until bug bug 1069300 is at least further along.
Attachment #8494155 -
Flags: review?(MattN+bmo)
Updated•10 years ago
|
Status: NEW → ASSIGNED
Flags: qe-verify?
Comment 3•10 years ago
|
||
Comment on attachment 8494155 [details] [diff] [review] Patch v.1 Review of attachment 8494155 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/modules/UITour.jsm @@ +97,5 @@ > }], > ["help", {query: "#PanelUI-help"}], > ["home", {query: "#home-button"}], > ["loop", {query: "#loop-call-button"}], > + ["panicButton", {query: "#panic-button"}], Nit: the "Button" suffix seems somewhat out of place given that none of the other buttons have this suffix.
Attachment #8494155 -
Flags: review?(MattN+bmo) → review+
Comment 4•10 years ago
|
||
I think that as long as it's only the ability and no tour that actually highlights it has been implemented, we cannot manually test it.
Flags: qe-verify? → qe-verify-
Comment 5•10 years ago
|
||
Comment on attachment 8494155 [details] [diff] [review] Patch v.1 Review of attachment 8494155 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/modules/UITour.jsm @@ +97,5 @@ > }], > ["help", {query: "#PanelUI-help"}], > ["home", {query: "#home-button"}], > ["loop", {query: "#loop-call-button"}], > + ["panicButton", {query: "#panic-button"}], Also, can you change this to the newer name "forget"?
Assignee | ||
Comment 6•10 years ago
|
||
Changed the name from "panicButton" to "forget", to address previous comment and to make the name we expose to the UITour API consistent with what the feature is called. https://hg.mozilla.org/integration/fx-team/rev/83f3c381d339
Attachment #8494155 -
Attachment is obsolete: true
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Matthew N. [:MattN] from comment #5) > Also, can you change this to the newer name "forget"? Ha, I made and landed that change 8 seconds before your comment. :)
Comment 8•10 years ago
|
||
I figured that since I got the mention from #developers just a few seconds after I commented. My other theory was that you have a time machine.
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/83f3c381d339
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8496221 [details] [diff] [review] Patch v.2 a+ for beta as this bug will be landing in the 33.x anniversary release. (It's already on Nightly + Aurora, so only needs a beta landing at this point.)
Attachment #8496221 -
Flags: approval-mozilla-beta+
Comment 11•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/d37b92959827
status-firefox34:
--- → fixed
Updated•10 years ago
|
status-firefox33:
--- → affected
status-firefox35:
--- → fixed
Assignee | ||
Comment 12•10 years ago
|
||
Landed in alder: https://hg.mozilla.org/projects/alder/rev/62fee88552f8
Whiteboard: [fixed-alder]
Comment 13•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-release/rev/62fee88552f8
Whiteboard: [fixed-alder]
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•