Closed Bug 1072036 Opened 7 years ago Closed 7 years ago

UI Tour: Add ability to highlight new privacy button

Categories

(Firefox :: General, defect)

defect
Not set
normal
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 35
Iteration:
35.2
Tracking Status
firefox33 --- fixed
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

Attachments

(1 file, 1 obsolete file)

If the user adds the new bug 1069300 button (using the new UITour feature from bug 1071238), it seems likely we'll want to then immediately hilight it. Trivial patch, so let's go ahead and do that.
Attached patch Patch v.1 (obsolete) — Splinter Review
Basically the same as bug 1068290.
Assignee: nobody → dolske
Iteration: --- → 35.2
Points: --- → 2
Flags: firefox-backlog+
Comment on attachment 8494155 [details] [diff] [review]
Patch v.1

Review of attachment 8494155 [details] [diff] [review]:
-----------------------------------------------------------------

Might as well get review, but I don't intend to land this until bug bug 1069300 is at least further along.
Attachment #8494155 - Flags: review?(MattN+bmo)
Status: NEW → ASSIGNED
Flags: qe-verify?
Comment on attachment 8494155 [details] [diff] [review]
Patch v.1

Review of attachment 8494155 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/modules/UITour.jsm
@@ +97,5 @@
>      }],
>      ["help",        {query: "#PanelUI-help"}],
>      ["home",        {query: "#home-button"}],
>      ["loop",        {query: "#loop-call-button"}],
> +    ["panicButton", {query: "#panic-button"}],

Nit: the "Button" suffix seems somewhat out of place given that none of the other buttons have this suffix.
Attachment #8494155 - Flags: review?(MattN+bmo) → review+
I think that as long as it's only the ability and no tour that actually highlights it has been implemented, we cannot manually test it.
Flags: qe-verify? → qe-verify-
Comment on attachment 8494155 [details] [diff] [review]
Patch v.1

Review of attachment 8494155 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/modules/UITour.jsm
@@ +97,5 @@
>      }],
>      ["help",        {query: "#PanelUI-help"}],
>      ["home",        {query: "#home-button"}],
>      ["loop",        {query: "#loop-call-button"}],
> +    ["panicButton", {query: "#panic-button"}],

Also, can you change this to the newer name "forget"?
Attached patch Patch v.2Splinter Review
Changed the name from "panicButton" to "forget", to address previous comment and to make the name we expose to the UITour API consistent with what the feature is called.

https://hg.mozilla.org/integration/fx-team/rev/83f3c381d339
Attachment #8494155 - Attachment is obsolete: true
(In reply to Matthew N. [:MattN] from comment #5)

> Also, can you change this to the newer name "forget"?

Ha, I made and landed that change 8 seconds before your comment. :)
I figured that since I got the mention from #developers just a few seconds after I commented. My other theory was that you have a time machine.
No longer blocks: fx10
https://hg.mozilla.org/mozilla-central/rev/83f3c381d339
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment on attachment 8496221 [details] [diff] [review]
Patch v.2

a+ for beta as this bug will be landing in the 33.x anniversary release. (It's already on Nightly + Aurora, so only needs a beta landing at this point.)
Attachment #8496221 - Flags: approval-mozilla-beta+
Landed in alder: https://hg.mozilla.org/projects/alder/rev/62fee88552f8
Whiteboard: [fixed-alder]
You need to log in before you can comment on or make changes to this bug.